From nobody Fri Jun 10 22:29:12 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 250A383D8B0; Fri, 10 Jun 2022 22:29:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LKbGy72yMz3nQn; Fri, 10 Jun 2022 22:29:14 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654900155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QRLHOqKttQ9Cf1mhlCIdN+PLl1/I7oe9XxJyzC4l0jU=; b=BA5HfiO+UlamxB/L3qRvYr+PMqFYh/aNjG/UpM4/MrtPxhRM5qsPjgUa2j8mbMDG3TFOoM oUwCUZOJmxortMl0j0ugQho9zTFEP8WEaGKedekYcWmT5DbBTon+b0BeXdNx778iSLvApm 7FNp4y+B65LFzBjY53QZp1R2Xe69yBi+FBrF1ryv3hBiG9vFTD6Kh92E2sMmk8KAD3vL8f 7HFbjYwOjscc9fyZYQu9gdmQlFb63ka3gA6mAcABzBYCDj4Ib8UO7WjZ/hfXrBRrpz/65a DTvW9G/4Bp0XS+5ug3jjwThLNzVWn4ZWn+ziFFPpxudMHhAxbr4Gm1M+zjL6jA== Received: from [IPV6:2601:648:8680:ed60:99d0:1b32:8e6e:2ffa] (unknown [IPv6:2601:648:8680:ed60:99d0:1b32:8e6e:2ffa]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 5BA1D31DF1; Fri, 10 Jun 2022 22:29:14 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Fri, 10 Jun 2022 15:29:12 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: Eric Joyner , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202205232354.24NNs69N032987@gitrepo.freebsd.org> From: John Baldwin Subject: Re: git: cdcd52d41e24 - main - irdma: Add RDMA driver for Intel(R) Ethernet Controller E810 In-Reply-To: <202205232354.24NNs69N032987@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654900155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QRLHOqKttQ9Cf1mhlCIdN+PLl1/I7oe9XxJyzC4l0jU=; b=fhe23ZReX/YCr992pNWmE3hCNeynJVGqJFCUKsjrRYYIhoU3m3QcHfdXp1Qp6WYp+me35A YASFPuoUJvZuLjz3RyKRa/JE4UiCvsJfa94PXH68qQbfU/bjGsM9LZ3sKc1cJWPecmB+wW sHxg/c7YtoLYTaEXkEkbALE6/f4v+nNL1xpywsQb94N2RlKpi+c6dKx7Xg9u3iIO1brwFR Zbl3fnrUJbgTFPO3uFAuN75SfGwyvpv7Oo4YyJgdObYZZR7p2P2FWRg325wrNq23tJwPeT Y3UqixTanfbaLzO7dVuEobHBXuy8/QQ6QwPz4p7JEEqU7iJ2KvVM8e6lUMCa+g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654900155; a=rsa-sha256; cv=none; b=Kwk+o8Zby/FwAwEf6847SKJrgwlsD03m6jxrqwaSkVtStZ7uYBOu+8PHcVl4YTc7EmbYwA KIFzMM+xFCq6BVZecnvRlBU5YrleMszdti3LmA6fywpd0lTyhNpNfjb6ALHOKMiuqHAo7e Fvj+X7ZG5T3qPvhGjDOMdbrPLuJ4pfIDMFqo3pP2lZpyaKYxudoboKYvjJoDX0HAaH1S40 kAGXzqeO39pbggv1Fhf0rfaaQJjW3BTAFYRG6Jhgt7tUG8aXyZhOWevGLfYNaoeDfIYssg IPu6mX9si6kigE350PGVdxpFsOupOBFpyfgjuJIj22sYWfO5msRKIGSBUSRY3Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 5/23/22 4:54 PM, Eric Joyner wrote: > The branch main has been updated by erj: > > URL: https://cgit.FreeBSD.org/src/commit/?id=cdcd52d41e246ba1c0fcfad0769bd691487355ef > > commit cdcd52d41e246ba1c0fcfad0769bd691487355ef > Author: Bartosz Sobczak > AuthorDate: 2022-05-23 23:39:27 +0000 > Commit: Eric Joyner > CommitDate: 2022-05-23 23:52:49 +0000 > > irdma: Add RDMA driver for Intel(R) Ethernet Controller E810 > > This is an initial commit for RDMA FreeBSD driver for Intel(R) Ethernet > Controller E810, called irdma. Supporting both RoCEv2 and iWARP > protocols in per-PF manner, RoCEv2 being the default. > > Testing has been done using krping tool, perftest, ucmatose, rping, > ud_pingpong, rc_pingpong and others. > > Signed-off-by: Eric Joyner > > Reviewed by: #manpages (pauamma_gundo.com) [documentation] > MFC after: 1 week > Relnotes: yes > Sponsored by: Intel Corporation > Differential Revision: https://reviews.freebsd.org/D34690 I'm trying to get the tree building again with GCC and ld.bfd does not like libirdma.map at all complaining with an error: duplicate expression '*' in version information I looked at the version map, and it seems rather bogus to me and not like version maps used anywhere else. It seems to be exporting all symbols in two different versions? That would seem to defeat the point of having symbol versions? /* Export symbols should be added below according to Documentation/versioning.md document. */ IRDMA_1.0 { global: *; local: *; }; IRDMA_1.1 { global: *; } IRDMA_1.0; (I'm also not sure why lld accepts such a version map.) -- John Baldwin