Re: git: 9e891d43f586 - main - unionfs: implement VOP_SET_TEXT/VOP_UNSET_TEXT

From: Shawn Webb <shawn.webb_at_hardenedbsd.org>
Date: Mon, 03 Jan 2022 14:07:12 UTC
On Mon, Jan 03, 2022 at 03:45:25AM +0000, Jason A. Harmening wrote:
> The branch main has been updated by jah:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=9e891d43f586e91541bd61fb12550de296d76fd9
> 
> commit 9e891d43f586e91541bd61fb12550de296d76fd9
> Author:     Jason A. Harmening <jah@FreeBSD.org>
> AuthorDate: 2021-12-21 23:51:51 +0000
> Commit:     Jason A. Harmening <jah@FreeBSD.org>
> CommitDate: 2022-01-03 03:52:58 +0000
> 
>     unionfs: implement VOP_SET_TEXT/VOP_UNSET_TEXT
>     
>     The implementation simply passes the text ref to the appropriate
>     underlying vnode.  Without this, the default [un]set_text
>     implementation will only manage the text ref on the unionfs vnode,
>     causing it to be out of sync with the underlying filesystems and
>     potentially allowing corruption of executable file contents.
>     On INVARIANTS kernels, it also readily produces a panic on process
>     termination because the VM object representing the executable mapping
>     is backed by the underlying vnode, not the unionfs vnode.
>     
>     PR:     251342
>     Reviewed by:    kib
>     Differential Revision: https://reviews.freebsd.org/D33611

Hey Jason,

Thanks for working on unionfs! I'm wondering if MFC'ing all the recent
unionfs work to 13-stable is planned (or possible).

Thanks,

-- 
Shawn Webb
Cofounder / Security Engineer
HardenedBSD

https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc