From nobody Mon Jan 03 14:07:12 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8DB08192DC39 for ; Mon, 3 Jan 2022 14:07:20 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JSHcm3FQpz3lK9 for ; Mon, 3 Jan 2022 14:07:20 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qv1-xf35.google.com with SMTP id ke6so31047468qvb.1 for ; Mon, 03 Jan 2022 06:07:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iXlO22jKoJiP+MCz7tORaZ0m/B787E/RSCVinfugxM4=; b=PV5IN++siwRLxCMHU1zVozIr1ugaDXiIg5jrY5CoDCJDNi75Yx0BlIrzgKjdUU0gxC SCINtwXZHDB30CIJylbtqixP28AgjQuTBbY4HhX1LJaN90YTHFxu/X1NbK5O6wELvIJA R5vfjiQodu0evdp6CYBk8cpmWUli5Gpj5Tat3Goop2jvI1Ia53rggvdYb6gflTBmb2/w b8EmC9vyWw5TOaKHVQM5T6Padj0YmOZ4XdfPXxNU+KZPIe0L9eZCU4IdRdTNeV8ALgQo Sc3N3HJsgckcXpgtpHNWPOVAULjTHrnP1PZjQEFK3ykzQ+vDSuszuGfyB4Je7uVz9lSf GQ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iXlO22jKoJiP+MCz7tORaZ0m/B787E/RSCVinfugxM4=; b=06ADYJ17UvztP4bwDM6Lw31FPHdokMcA2YXtL8pwtMOi0jVyD2rVnuj88b8kEaQJFk DX+TPbYjY2T5kX0a7hf2wDXkiv412WbfVOqHBMuP6fP9ZdH8m4zFYbyyqBTzpKgBVJDp e77fNtSCTTFWLDQtPDEJixX8PWwAtwolzpflOzG4PPrZMsXOGmTis/cJjIEsANZg+irP FmRq+fun7Xp1rIS3bmhaq+FpNmDQenrqTAlyDvc2K8FnjtIEYs7Ql2w2qTmngWW53Dw6 cPNRZjAXisjuQPZfQ/pLvBeD1GfBLFcDjVuBKYAzyV+rkd0dFlmb/JwvO32o/tF+HUCB HGaA== X-Gm-Message-State: AOAM531kGuI93mfuMMT5R6nbuDR56sg9LCnHetj9V8LHEHO8ETBcihxX S7OjXwF2JFp2T6VkZjzHzwWIww== X-Google-Smtp-Source: ABdhPJwCEImvxEbkAA+/JhvGsBFN5HqzMZTmQAhXycCfFQPrq3uh3gW0hDrIcEWPS2tpT/5xOlgi2g== X-Received: by 2002:a05:6214:5286:: with SMTP id kj6mr41539032qvb.74.1641218833782; Mon, 03 Jan 2022 06:07:13 -0800 (PST) Received: from mutt-hbsd (pool-100-16-224-136.bltmmd.fios.verizon.net. [100.16.224.136]) by smtp.gmail.com with ESMTPSA id w7sm25779330qkj.119.2022.01.03.06.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jan 2022 06:07:13 -0800 (PST) Date: Mon, 3 Jan 2022 09:07:12 -0500 From: Shawn Webb To: "Jason A. Harmening" Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 9e891d43f586 - main - unionfs: implement VOP_SET_TEXT/VOP_UNSET_TEXT Message-ID: <20220103140712.txfy3jj6hvdnutxt@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202201030345.2033jP6T052711@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gk4jwmfzkj6jv4wo" Content-Disposition: inline In-Reply-To: <202201030345.2033jP6T052711@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4JSHcm3FQpz3lK9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --gk4jwmfzkj6jv4wo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 03, 2022 at 03:45:25AM +0000, Jason A. Harmening wrote: > The branch main has been updated by jah: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D9e891d43f586e91541bd61fb12= 550de296d76fd9 >=20 > commit 9e891d43f586e91541bd61fb12550de296d76fd9 > Author: Jason A. Harmening > AuthorDate: 2021-12-21 23:51:51 +0000 > Commit: Jason A. Harmening > CommitDate: 2022-01-03 03:52:58 +0000 >=20 > unionfs: implement VOP_SET_TEXT/VOP_UNSET_TEXT > =20 > The implementation simply passes the text ref to the appropriate > underlying vnode. Without this, the default [un]set_text > implementation will only manage the text ref on the unionfs vnode, > causing it to be out of sync with the underlying filesystems and > potentially allowing corruption of executable file contents. > On INVARIANTS kernels, it also readily produces a panic on process > termination because the VM object representing the executable mapping > is backed by the underlying vnode, not the unionfs vnode. > =20 > PR: 251342 > Reviewed by: kib > Differential Revision: https://reviews.freebsd.org/D33611 Hey Jason, Thanks for working on unionfs! I'm wondering if MFC'ing all the recent unionfs work to 13-stable is planned (or possible). Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --gk4jwmfzkj6jv4wo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmHTAw0ACgkQ/y5nonf4 4fr+xA/+K+0NiKkeazHXk4Br7jYZIcoHzFWihUSq5Xu+y+OIxEScstvyMzrfPlfl Xs+EKNGviwLASFB4FVnJuWLYVRsDD0AjJSgg9psmV24PDKY9oxn6xA7qsRgVKdfi PFa/Cf1reDbj1zZzkyb/6VJ8ZdnAjhQijwyhqfvJLeGqJ3dL7dNHcmhtOnuKYnAy z1tfft84sujPNOrrKdH8z9JXmNQr97NIjRMHVVjpXMpvZtOd/MW93zfRgqS7d8kl oZgbvJhAOGpDh6aPwOA8NZWIeJUNuRwjN8IF76aELH9ZK9gPgEDnnh4F3vPzYaun nwEMq+QXf7TUA0w2zTYXbsmw10Qt4U2YlyiKXj3gyDrFZhE3m0q/3ywtMlDQaDj5 Jffu9BJ4tQkb1lthhDe6+d12BCOkoYOgRSzreLpCpBoeXNXkmjNOukgRaU0N0Hpw Qdik/ZV8+lgmciyildGIHfEFr9Jmzs0AEIImF/qUckf9sk/URr56yfMNNGr6czYH 3JNOhSeiY34ITiS6R8MBpVWInViFGjgduBujpEXn09MOrGLoM/WAGw/QN3GFkC5S jL2zrAD7fhATVEjzpNUgjQ/oGZ504TbAL2IBBwBf66N8tMQ8IQbidjEzkHC5GAjY JPh1QbEZSz3sd5A3gP7HxWk52SWYSGgam8V6HcVltJrU/nVCDwk= =enD7 -----END PGP SIGNATURE----- --gk4jwmfzkj6jv4wo--