Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning
- Reply: Warner Losh : "Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning"
- In reply to: Dimitry Andric : "Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 16 Aug 2022 12:50:50 UTC
On Tue, Aug 16, 2022 at 02:41:51PM +0200, Dimitry Andric wrote: > On 2022-08-16 13:47, Alexey Dokuchaev wrote: > > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: > >> ... > >> But I think it is better to have the definitions matching the > >> declarations exactly. We should sweep through the whole tree and get > >> rid of all K&R functions too. I believe Warner wanted to attempt that. > > > > I won't comment on the technical side of things, but seeing this plethora > > of identical commits is not just annoying, but pessimizes blaming as well. > > I don't see any reason why this would "pessimize blaming"? What do you > mean with that? Sorry, I've meant bisecting. Not sure why I used that word. > Because then somebody else will probably complain "why everything in one > commit, it should be fine-grained"? I see; well, I believe a reasonable balance could be achieved, there are a lot of numbers between 1 and 100. :) ./danfe