From nobody Tue Aug 16 12:50:50 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M6WGf40gBz4Z21n; Tue, 16 Aug 2022 12:50:50 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M6WGf3Xfgz4LQq; Tue, 16 Aug 2022 12:50:50 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660654250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rvM4xOA3ZvSAngd0V/rKCm4Mo/ZEfrCIVrGpUn0OKtg=; b=YK/cbNH+aYKQWclwMn4ERShIUdFJCebJRovdYrV/yoEb1ZptunGETD/RHzENdVHIOXKYeT 84S8LbGbJLT64h7Lu86RzBNU2w7ZUXRfPLUUlucA7iYltcyC9XchZtN4WJJ8QOcX7TWA/p Fb1viuKfXOPaweac3IoZLgZBYsoqcKHIsN/j2RQS6lWGNmbBYTwyP/A+rh/zELWUyfcjOC 2GY+DMOPaklaDLSj6hQYrYSCY4Wn5YTX/aHOGfSHg63monRA+N/C0ZmusgpD3I92yv3p2h oHy0ibaoYDQ/y7jCBT9G9iOychRxk+g+q3sD7A0SGcDx/qwBCujGgPfHBSFxDg== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 69F1899CA; Tue, 16 Aug 2022 12:50:50 +0000 (UTC) Date: Tue, 16 Aug 2022 12:50:50 +0000 From: Alexey Dokuchaev To: Dimitry Andric Cc: Jessica Clarke , Konstantin Belousov , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning Message-ID: References: <202208151849.27FInHmh027652@gitrepo.freebsd.org> <4ed11043-d368-3084-bb21-2b794e9da748@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ed11043-d368-3084-bb21-2b794e9da748@FreeBSD.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660654250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rvM4xOA3ZvSAngd0V/rKCm4Mo/ZEfrCIVrGpUn0OKtg=; b=vWSqADQGbJww+rYkgXVYBfSTlzDAqwpH3NkGtRbyJ8riMRd6Ft26GSghAfJrcDxVGn7aLS J+q2nVq5ibFpNNSLqUcHl05XyeSMmTruL1nevfOx7rtkfk5x9iGYprfdkIo/gDoJ/usd2E KfQhgPId8RaGtI0mzNE/AAoYzenIa6opf70GiZqeydwjVe0vQWax5gSqO1kQVTEY0S1Ori 1GxmAd+ocjlHfRfAh0gnbGewxoGYDtSyyf8evLazaAKkjI8Ygs1vEq6fCZgEs71o1Lif94 LqQh1ASe1mbKIhBlaU0sOWe2rRhisZQatkluSl8Y9z6+Bxpg3/MtnMem4TrV+g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660654250; a=rsa-sha256; cv=none; b=Vcl969j/Zxdi2BlbYDFH/Gas0cXUlH+svJ6fIaafeMmmd6zdu//2lSJktu/AAZ1/KHUFvM I0DTE4BZD6NjMJFMW1MHvEMOI3NGCIK35knD5Jl9W0wH4ysx4IwJqxs5LsekLvkvAEBT7x KcGeq059waMx60jk4ng0jkQztcxq0gB5urWkmGelWKBC0Tj6j7gPBkv8TO9092Sf1AuAax p70XMzDoCXx0jBVACA+KiGYE8oW9D0OuJoRWjM4yzQdJcV/gDIEey2ryB7E6jX9ltLjI0p ey5eWN9Sugluf0LWrunazlE9yIdtc31+YZ8Jcydk4oksVNamEcAw0O4A7cnAxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Tue, Aug 16, 2022 at 02:41:51PM +0200, Dimitry Andric wrote: > On 2022-08-16 13:47, Alexey Dokuchaev wrote: > > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: > >> ... > >> But I think it is better to have the definitions matching the > >> declarations exactly. We should sweep through the whole tree and get > >> rid of all K&R functions too. I believe Warner wanted to attempt that. > > > > I won't comment on the technical side of things, but seeing this plethora > > of identical commits is not just annoying, but pessimizes blaming as well. > > I don't see any reason why this would "pessimize blaming"? What do you > mean with that? Sorry, I've meant bisecting. Not sure why I used that word. > Because then somebody else will probably complain "why everything in one > commit, it should be fine-grained"? I see; well, I believe a reasonable balance could be achieved, there are a lot of numbers between 1 and 100. :) ./danfe