Re: git: 29029b06a6f7 - main - routing: remove info argument from add/change_route_nhop().

In message <E8FB4630-270C-4842-B538-1A2EEA22E8B5@ipfw.ru>, "Alexander V. 
Cherni
kov" writes:
> 
>
>
> > On 2 Aug 2022, at 20:41, Cy Schubert <Cy.Schubert@cschubert.com> =
> wrote:
> >=20
> > In message <202208010853.2718rMqh090712@gitrepo.freebsd.org>, =
> "Alexander V.=20
> > Che
> > rnikov" writes:
> >> The branch main has been updated by melifaro:
> >>=20
> >> URL: =
> https://cgit.FreeBSD.org/src/commit/?id=3D29029b06a6f7fd51c34c9db88cc98a66=
>
> >> 53ee5046
> >>=20
> >> commit 29029b06a6f7fd51c34c9db88cc98a6653ee5046
> >> Author: Alexander V. Chernikov <melifaro@FreeBSD.org>
> >> AuthorDate: 2022-07-28 13:41:11 +0000
> >> Commit: Alexander V. Chernikov <melifaro@FreeBSD.org>
> >> CommitDate: 2022-08-01 07:41:07 +0000
> >>=20
> >> routing: remove info argument from add/change_route_nhop().
> >>=20
> >> Currently, rt_addrinfo(info) serves as a main "transport" moving
> >> state between various functions inside the routing subsystem.
> >> As all of the fields are filled in directly by the customers, it
> >> is problematic to maintain consistency, resulting in repeated checks
> >> inside many functions. Additionally, there are multiple ways of
> >> specifying the same value (RTAX_IFP vs rti_ifp / rti_ifa) and so on.
> >> With the upcoming nhop(9) kpi it is possible to store all of the
> >> required state in the nexthops in the consistent fashion, reducing =
> the
> >> need to use "info" in the KPI calls.
> >> Finally, rt_addrinfo structure format was derived from the rtsock =
> wire
> >> format, which is different from other kernel routing users or =
> netlink.
> >>=20
> >> This cleanup simplifies upcoming nhop(9) kpi and netlink =
> introduction.
> >>=20
> >> Reviewed by: zlei.huang@gmail.com
> >> Differential Revision: https://reviews.freebsd.org/D35972
> >> MFC after: 2 weeks
> >=20
> > Hi,
> >=20
> > Just picking this commit:
> >=20
> > One of these routing commits has caused a panic during setup of gif(4) =
> to=20
> > Tunnelbroker.
> Sorry for the breakage, should be fixed by 08bb0873ca88.

Thanks. Confirmed it's fixed.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e**(i*pi)+1=0