From nobody Wed Aug 03 14:26:14 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LyZ0n0kMkz4XmtG; Wed, 3 Aug 2022 14:26:17 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LyZ0m6ZJkz3jT4; Wed, 3 Aug 2022 14:26:16 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTP id J4q6oVdxHSp39JFKCoCxCo; Wed, 03 Aug 2022 14:26:16 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id JFKAocES5GRNlJFKBosaLi; Wed, 03 Aug 2022 14:26:16 +0000 X-Authority-Analysis: v=2.4 cv=Sfrky9du c=1 sm=1 tr=0 ts=62ea8588 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=biHskzXt2R4A:10 a=sVRy8H1vAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=pGLkceISAAAA:8 a=EkcXrb_YAAAA:8 a=sNw70EGo7kn8D6g0KTAA:9 a=CjuIK1q_8ugA:10 a=mL5YggztzNiiHV2pp1Gt:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 565C0B6; Wed, 3 Aug 2022 07:26:14 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 29A5F14; Wed, 3 Aug 2022 07:26:14 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Alexander V. Chernikov" cc: Cy Schubert , "Alexander V. Chernikov" , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 29029b06a6f7 - main - routing: remove info argument from add/change_route_nhop(). In-reply-to: References: <202208010853.2718rMqh090712@gitrepo.freebsd.org> <20220802194127.3D45EC4@slippy.cwsent.com> Comments: In-reply-to "Alexander V. Chernikov" message dated "Wed, 03 Aug 2022 10:18:53 +0100." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 03 Aug 2022 07:26:14 -0700 Message-Id: <20220803142614.29A5F14@slippy.cwsent.com> X-CMAE-Envelope: MS4xfENsTpWnwJigXYgjwNTK6zjQ7Myew1fz88/nCAvfDpAOoRDU2Q5tVxcnBELdkhaoLGl2H6Ss2nw7zABhX0r1DLtssH5+IFzJctNht9//BK7TbwyNCWoj PD2J9MK6ZNNBIURwsI1LeP/jR/xGReMXmoKKnCToxJzjydMrQ3bgDgwnBKwHYhCt8PD2UWxoe0FgrxnMgYqiYttA7nKIPgqIkHDd2JlTt6v2nd+LyKFBremd fHihWYmVNhtbtb/1CzUAKCe1IjfuG3KvufDAyAnmHRpTDZIlZvXT/ICH2L19catuXsnxr1I2QelOVyWGPC+0/bwC/ozhu84tQZfBDl56nCw8MZiUn09MZ2eJ 8pUS55gS X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4LyZ0m6ZJkz3jT4 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N In message , "Alexander V. Cherni kov" writes: > > > > > On 2 Aug 2022, at 20:41, Cy Schubert = > wrote: > >=20 > > In message <202208010853.2718rMqh090712@gitrepo.freebsd.org>, = > "Alexander V.=20 > > Che > > rnikov" writes: > >> The branch main has been updated by melifaro: > >>=20 > >> URL: = > https://cgit.FreeBSD.org/src/commit/?id=3D29029b06a6f7fd51c34c9db88cc98a66= > > >> 53ee5046 > >>=20 > >> commit 29029b06a6f7fd51c34c9db88cc98a6653ee5046 > >> Author: Alexander V. Chernikov > >> AuthorDate: 2022-07-28 13:41:11 +0000 > >> Commit: Alexander V. Chernikov > >> CommitDate: 2022-08-01 07:41:07 +0000 > >>=20 > >> routing: remove info argument from add/change_route_nhop(). > >>=20 > >> Currently, rt_addrinfo(info) serves as a main "transport" moving > >> state between various functions inside the routing subsystem. > >> As all of the fields are filled in directly by the customers, it > >> is problematic to maintain consistency, resulting in repeated checks > >> inside many functions. Additionally, there are multiple ways of > >> specifying the same value (RTAX_IFP vs rti_ifp / rti_ifa) and so on. > >> With the upcoming nhop(9) kpi it is possible to store all of the > >> required state in the nexthops in the consistent fashion, reducing = > the > >> need to use "info" in the KPI calls. > >> Finally, rt_addrinfo structure format was derived from the rtsock = > wire > >> format, which is different from other kernel routing users or = > netlink. > >>=20 > >> This cleanup simplifies upcoming nhop(9) kpi and netlink = > introduction. > >>=20 > >> Reviewed by: zlei.huang@gmail.com > >> Differential Revision: https://reviews.freebsd.org/D35972 > >> MFC after: 2 weeks > >=20 > > Hi, > >=20 > > Just picking this commit: > >=20 > > One of these routing commits has caused a panic during setup of gif(4) = > to=20 > > Tunnelbroker. > Sorry for the breakage, should be fixed by 08bb0873ca88. Thanks. Confirmed it's fixed. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0