git: 7000dd2e2912 - stable/13 - liquidio(4): Stop checking for failures from malloc/taskqueue_create/buf_ring_alloc(M_WAITOK)

The branch stable/13 has been updated by zlei:

URL: https://cgit.FreeBSD.org/src/commit/?id=7000dd2e2912c15209f7e60538f8e7ba8f525339

commit 7000dd2e2912c15209f7e60538f8e7ba8f525339
Author:     Zhenlei Huang <zlei@FreeBSD.org>
AuthorDate: 2024-09-03 10:25:38 +0000
Commit:     Zhenlei Huang <zlei@FreeBSD.org>
CommitDate: 2024-09-30 05:05:43 +0000

    liquidio(4): Stop checking for failures from malloc/taskqueue_create/buf_ring_alloc(M_WAITOK)
    
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D45853
    
    (cherry picked from commit 57cd8f27b727e7a87312f6f141cfa13807dc81a0)
    (cherry picked from commit 518e138448b46d57030b3e34962e69e6211c8e1b)
---
 sys/dev/liquidio/base/lio_request_manager.c  | 9 ---------
 sys/dev/liquidio/base/lio_response_manager.c | 4 ----
 sys/dev/liquidio/lio_main.c                  | 4 ----
 sys/dev/liquidio/lio_sysctl.c                | 3 ---
 4 files changed, 20 deletions(-)

diff --git a/sys/dev/liquidio/base/lio_request_manager.c b/sys/dev/liquidio/base/lio_request_manager.c
index 75dabf4839a7..fedf0ee17893 100644
--- a/sys/dev/liquidio/base/lio_request_manager.c
+++ b/sys/dev/liquidio/base/lio_request_manager.c
@@ -159,11 +159,6 @@ lio_init_instr_queue(struct octeon_device *oct, union octeon_txpciq txpciq,
 	db_tq = &oct->check_db_tq[iq_no];
 	db_tq->tq = taskqueue_create("lio_check_db_timeout", M_WAITOK,
 				     taskqueue_thread_enqueue, &db_tq->tq);
-	if (db_tq->tq == NULL) {
-		lio_dev_err(oct, "check db wq create failed for iq %d\n",
-			    iq_no);
-		return (1);
-	}
 
 	TIMEOUT_TASK_INIT(db_tq->tq, &db_tq->work, 0, lio_check_db_timeout,
 			  (void *)db_tq);
@@ -179,10 +174,6 @@ lio_init_instr_queue(struct octeon_device *oct, union octeon_txpciq txpciq,
 	oct->instr_queue[iq_no]->br =
 		buf_ring_alloc(LIO_BR_SIZE, M_DEVBUF, M_WAITOK,
 			       &oct->instr_queue[iq_no]->enq_lock);
-	if (oct->instr_queue[iq_no]->br == NULL) {
-		lio_dev_err(oct, "Critical Failure setting up buf ring\n");
-		return (1);
-	}
 
 	return (0);
 }
diff --git a/sys/dev/liquidio/base/lio_response_manager.c b/sys/dev/liquidio/base/lio_response_manager.c
index 12a3ad60521e..ac5fc6229885 100644
--- a/sys/dev/liquidio/base/lio_response_manager.c
+++ b/sys/dev/liquidio/base/lio_response_manager.c
@@ -59,10 +59,6 @@ lio_setup_response_list(struct octeon_device *oct)
 	ctq = &oct->dma_comp_tq;
 	ctq->tq = taskqueue_create("lio_dma_comp", M_WAITOK,
 				   taskqueue_thread_enqueue, &ctq->tq);
-	if (ctq->tq == NULL) {
-		lio_dev_err(oct, "failed to create wq thread\n");
-		return (-ENOMEM);
-	}
 
 	TIMEOUT_TASK_INIT(ctq->tq, &ctq->work, 0, lio_poll_req_completion,
 			  (void *)ctq);
diff --git a/sys/dev/liquidio/lio_main.c b/sys/dev/liquidio/lio_main.c
index 54878bc6a12c..9b990282d7f5 100644
--- a/sys/dev/liquidio/lio_main.c
+++ b/sys/dev/liquidio/lio_main.c
@@ -1863,10 +1863,6 @@ lio_setup_rx_oom_poll_fn(struct ifnet *ifp)
 	rx_status_tq->tq = taskqueue_create("lio_rx_oom_status", M_WAITOK,
 					    taskqueue_thread_enqueue,
 					    &rx_status_tq->tq);
-	if (rx_status_tq->tq == NULL) {
-		lio_dev_err(oct, "unable to create lio rx oom status tq\n");
-		return (-1);
-	}
 
 	TIMEOUT_TASK_INIT(rx_status_tq->tq, &rx_status_tq->work, 0,
 			  lio_poll_check_rx_oom_status, (void *)rx_status_tq);
diff --git a/sys/dev/liquidio/lio_sysctl.c b/sys/dev/liquidio/lio_sysctl.c
index e9ad95772164..5228077b8af8 100644
--- a/sys/dev/liquidio/lio_sysctl.c
+++ b/sys/dev/liquidio/lio_sysctl.c
@@ -744,9 +744,6 @@ lio_get_regs(SYSCTL_HANDLER_ARGS)
 	regbuf = malloc(sizeof(char) * LIO_REGDUMP_LEN_XXXX, M_DEVBUF,
 			M_WAITOK | M_ZERO);
 
-	if (regbuf == NULL)
-		return (error);
-
 	switch (oct->chip_id) {
 	case LIO_CN23XX_PF_VID:
 		len += lio_cn23xx_pf_read_csr_reg(regbuf, oct);