From nobody Mon Sep 30 05:08:49 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XH8HQ07jcz5XlsK; Mon, 30 Sep 2024 05:08:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XH8HP3ZSnz4Y08; Mon, 30 Sep 2024 05:08:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727672929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZQzuqgjEwi4ZImrrMbdvKNjkMk+MLflnbYch0SsoNcQ=; b=ul7YhE96nbdjUAuX21VFs5k4YZgUB/leBPrNSqvbtwyCbouhPzpVvTAxPjiv/vFJXvw0bz 1L/ovqCtUsqBNlPppl7l9h1SnOBYh442CBjha5+u8HJ9zdo/iun5NLNxulQm/4cM42CDeo He8qDuzOcIJD7PxSDPJnb0JOwmC7f5IZBUbM+J/E/+HYBT87/2iR0cfXRMaL9JauO6Y41h ymKOxfDRd/xNePucPZg7682fz5zr1125jZ2DSmbUZnaW5+Ok2umsNM8wLKyLnY03VZk6uM kxYvCdLsqJ6ByXINyb9rKXi1hkVgbnO/MtCH71mDbkncqWphPCD/BoYkr6xwfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727672929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZQzuqgjEwi4ZImrrMbdvKNjkMk+MLflnbYch0SsoNcQ=; b=JW7xDRtauBVBf+0RBeLyCWl4b0NU0R2v8/IhKTX/joGPK8MSGFZgE90itUklpghxK1vjLm eej1D6rSknjgR39wrZeR2FT5x7T8WaVMxQWkaIQydeiuWl6FAPoIwNMnY+nxIl6ZLVkEn/ KRBUP9bicJmXT4x8APYl9HdYWyBWYeu9jY/9XToFiJ6eJirRehRUk6ZTkAXAIeT1lXwGc7 ifF2iRWk68v4n8lmwGTbTnp9q/8ESXaY8QuJPwW1NVeLEOr6oIvwSesJmRZcr3Lcx4QLGI 2St/vRKYPAnosGm4nME2EiazNxbfp1yAkGqBHd4zVeYYX1odHCSlxMxZBTk4Qw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727672929; a=rsa-sha256; cv=none; b=QZnq8CtC0JykDWILwT6U4AdF1v3hbexLCpU6P7NGuKqF9LB0iLkQvCaiYofgJ2/HoQJQXy KywjkhWhuksRmszAZz5CmFITurjFmEEOhpiu7faYWRPGhPisS0wom1n/7xlkxFqYhwxaSB xauTAKcJTXv/TWn97fDdXRFI9c6ZxKJiIz6QzD6NLJeJG341icOp/LGxoMif3+wSaEn+Mc /jfPGruLVyQjgBFRj9kPuqHusdYmdFrasJyGOwDRWdAZe5kC+tE96FzlEqIcsebzOkQxJg CGt9RUSe4tSNRz0jLTbZ0Ipyb6Ww+b09yy8noIkkULlpinyOIxzX5Pm7ClhwRA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XH8HP3B1lzgDW; Mon, 30 Sep 2024 05:08:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48U58nOx026157; Mon, 30 Sep 2024 05:08:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48U58nC3026154; Mon, 30 Sep 2024 05:08:49 GMT (envelope-from git) Date: Mon, 30 Sep 2024 05:08:49 GMT Message-Id: <202409300508.48U58nC3026154@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: 7000dd2e2912 - stable/13 - liquidio(4): Stop checking for failures from malloc/taskqueue_create/buf_ring_alloc(M_WAITOK) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 7000dd2e2912c15209f7e60538f8e7ba8f525339 Auto-Submitted: auto-generated The branch stable/13 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=7000dd2e2912c15209f7e60538f8e7ba8f525339 commit 7000dd2e2912c15209f7e60538f8e7ba8f525339 Author: Zhenlei Huang AuthorDate: 2024-09-03 10:25:38 +0000 Commit: Zhenlei Huang CommitDate: 2024-09-30 05:05:43 +0000 liquidio(4): Stop checking for failures from malloc/taskqueue_create/buf_ring_alloc(M_WAITOK) MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D45853 (cherry picked from commit 57cd8f27b727e7a87312f6f141cfa13807dc81a0) (cherry picked from commit 518e138448b46d57030b3e34962e69e6211c8e1b) --- sys/dev/liquidio/base/lio_request_manager.c | 9 --------- sys/dev/liquidio/base/lio_response_manager.c | 4 ---- sys/dev/liquidio/lio_main.c | 4 ---- sys/dev/liquidio/lio_sysctl.c | 3 --- 4 files changed, 20 deletions(-) diff --git a/sys/dev/liquidio/base/lio_request_manager.c b/sys/dev/liquidio/base/lio_request_manager.c index 75dabf4839a7..fedf0ee17893 100644 --- a/sys/dev/liquidio/base/lio_request_manager.c +++ b/sys/dev/liquidio/base/lio_request_manager.c @@ -159,11 +159,6 @@ lio_init_instr_queue(struct octeon_device *oct, union octeon_txpciq txpciq, db_tq = &oct->check_db_tq[iq_no]; db_tq->tq = taskqueue_create("lio_check_db_timeout", M_WAITOK, taskqueue_thread_enqueue, &db_tq->tq); - if (db_tq->tq == NULL) { - lio_dev_err(oct, "check db wq create failed for iq %d\n", - iq_no); - return (1); - } TIMEOUT_TASK_INIT(db_tq->tq, &db_tq->work, 0, lio_check_db_timeout, (void *)db_tq); @@ -179,10 +174,6 @@ lio_init_instr_queue(struct octeon_device *oct, union octeon_txpciq txpciq, oct->instr_queue[iq_no]->br = buf_ring_alloc(LIO_BR_SIZE, M_DEVBUF, M_WAITOK, &oct->instr_queue[iq_no]->enq_lock); - if (oct->instr_queue[iq_no]->br == NULL) { - lio_dev_err(oct, "Critical Failure setting up buf ring\n"); - return (1); - } return (0); } diff --git a/sys/dev/liquidio/base/lio_response_manager.c b/sys/dev/liquidio/base/lio_response_manager.c index 12a3ad60521e..ac5fc6229885 100644 --- a/sys/dev/liquidio/base/lio_response_manager.c +++ b/sys/dev/liquidio/base/lio_response_manager.c @@ -59,10 +59,6 @@ lio_setup_response_list(struct octeon_device *oct) ctq = &oct->dma_comp_tq; ctq->tq = taskqueue_create("lio_dma_comp", M_WAITOK, taskqueue_thread_enqueue, &ctq->tq); - if (ctq->tq == NULL) { - lio_dev_err(oct, "failed to create wq thread\n"); - return (-ENOMEM); - } TIMEOUT_TASK_INIT(ctq->tq, &ctq->work, 0, lio_poll_req_completion, (void *)ctq); diff --git a/sys/dev/liquidio/lio_main.c b/sys/dev/liquidio/lio_main.c index 54878bc6a12c..9b990282d7f5 100644 --- a/sys/dev/liquidio/lio_main.c +++ b/sys/dev/liquidio/lio_main.c @@ -1863,10 +1863,6 @@ lio_setup_rx_oom_poll_fn(struct ifnet *ifp) rx_status_tq->tq = taskqueue_create("lio_rx_oom_status", M_WAITOK, taskqueue_thread_enqueue, &rx_status_tq->tq); - if (rx_status_tq->tq == NULL) { - lio_dev_err(oct, "unable to create lio rx oom status tq\n"); - return (-1); - } TIMEOUT_TASK_INIT(rx_status_tq->tq, &rx_status_tq->work, 0, lio_poll_check_rx_oom_status, (void *)rx_status_tq); diff --git a/sys/dev/liquidio/lio_sysctl.c b/sys/dev/liquidio/lio_sysctl.c index e9ad95772164..5228077b8af8 100644 --- a/sys/dev/liquidio/lio_sysctl.c +++ b/sys/dev/liquidio/lio_sysctl.c @@ -744,9 +744,6 @@ lio_get_regs(SYSCTL_HANDLER_ARGS) regbuf = malloc(sizeof(char) * LIO_REGDUMP_LEN_XXXX, M_DEVBUF, M_WAITOK | M_ZERO); - if (regbuf == NULL) - return (error); - switch (oct->chip_id) { case LIO_CN23XX_PF_VID: len += lio_cn23xx_pf_read_csr_reg(regbuf, oct);