git: f84956ab3781 - stable/14 - al_eth: improve TCP LRO

From: Michael Tuexen <tuexen_at_FreeBSD.org>
Date: Thu, 31 Oct 2024 13:41:12 UTC
The branch stable/14 has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=f84956ab37819227f488adde81d4cdbba34ce47a

commit f84956ab37819227f488adde81d4cdbba34ce47a
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2024-09-05 15:35:40 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2024-10-31 11:19:40 +0000

    al_eth: improve TCP LRO
    
    Use the appropriate function to flush correctly all entries. The old
    code does not remove the element from the hash table, only from the
    active queue.
    
    Reviewed by:            Peter Lei, rscheff
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D46434
    
    (cherry picked from commit 0b45d36510d8c629fcc49805bc64e5893f4ba63c)
---
 sys/dev/al_eth/al_eth.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/sys/dev/al_eth/al_eth.c b/sys/dev/al_eth/al_eth.c
index b4fbf041660b..1b976e7a724c 100644
--- a/sys/dev/al_eth/al_eth.c
+++ b/sys/dev/al_eth/al_eth.c
@@ -1581,7 +1581,6 @@ al_eth_rx_recv_work(void *arg, int pending)
 {
 	struct al_eth_ring *rx_ring = arg;
 	struct mbuf *mbuf;
-	struct lro_entry *queued;
 	unsigned int qid = rx_ring->ring_id;
 	struct al_eth_pkt *hal_pkt = &rx_ring->hal_pkt;
 	uint16_t next_to_clean = rx_ring->next_to_clean;
@@ -1672,10 +1671,7 @@ al_eth_rx_recv_work(void *arg, int pending)
 		    "%s: not filling rx queue %d\n", __func__, qid);
 	}
 
-	while (((queued = LIST_FIRST(&rx_ring->lro.lro_active)) != NULL)) {
-		LIST_REMOVE(queued, next);
-		tcp_lro_flush(&rx_ring->lro, queued);
-	}
+	tcp_lro_flush_all(&rx_ring->lro);
 
 	if (napi != 0) {
 		rx_ring->enqueue_is_running = 0;