From nobody Thu Oct 31 13:41:12 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XfQBJ5YJbz5bjWs; Thu, 31 Oct 2024 13:41:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XfQBJ3zq2z4sTY; Thu, 31 Oct 2024 13:41:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730382072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hbp9UpiI9iMbo1vjRbT+7i89Aqn1NtcWuZlZSDX7npw=; b=hCfvc0Zt0rJNC5P6ZJS6RL3RYm6ouSnfA85mL/qn/vNP6A6BCjLr4gWV4VieL96zlkgrbK yqH8JVfIL5KshJrACEpODMe2Rd+z4S6OHhnX6nPMvh0qOxqpijL7HV5S7wo7jmc95RYkiJ jW8K4DeV+y1wS05paHyx2qS1tqYnxBbBVv6YuDQDqcQ1kYYKY3znWwzvQNYw/iBPnnci5x YCgQ3px3fQXIlB7hnXe3M/GAb2VhXdrm9CpkLZ3Vw0+wQXykNywPJ7gRI/82ZYWHNWFPMc Mju3ksdW9+5AsHyStBVFgPavQlXCSMO+jQhqb8eL/UIekhKcDmOZqaIGgOJ8Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730382072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hbp9UpiI9iMbo1vjRbT+7i89Aqn1NtcWuZlZSDX7npw=; b=UHQH6C7JtEpwx5NuIkJY15Gk0TBTeLYk9ao+BiG2VTnPvqAsSSa2Mq/1u0KhJWMQum/uE7 BA79SzImpOu+s+LPy6MxCUsqENTuM+462eWGSQQrStloZJktUdnztdV/GWrNiwrquw2Vpd 0SDrecNPBF2nq8lD25xC3il1a89X+gXKPn4RYH0n0yWOSggu9mppO5BMShxZ6/YFEWZ1rA sePl4XkLMwFc/tqLBtj/iaeEn4zFP7QysS8mho033cyaIbCMqjx4ZwBU7lfHhi1VcqPx30 ysZqo36X/M6IcTeQ/0DtI2aw6Tc4qLlpwghu7+mpJHT3xoxNMmOztgKkIOYwUA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730382072; a=rsa-sha256; cv=none; b=OaO703fZXjLEZr7sHACMnoH1VKgllF1iXZbCMjVOxIDOlcD9+//+4TA9tOgTIXq2kUOzHZ QwCYzDauVHtChHH9z23l3LpyeGhNW5cOnGusgySdDTX87IiVolJurIOaxi7UYlRN3yYiWa ixVmAhWoNUaJYZQCkpvMDa42irLXivDGUxqJuftDqfA6Ei5xWEJU3Xw5ScgTNk80BQHQgj UzQT9fZ3GiTnHjobpYE9mdmEfIBKEmi9KRzPzT0T41nkblyegPzFlJhD9w7Nt2T3lwZ/AU RI6UiDX7BEpLfKSa7EqAY+6bbefBHm2eMqxKyyK8db3SsvTCTqWICXfEwRhx/g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XfQBJ3Ng9zf5j; Thu, 31 Oct 2024 13:41:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49VDfCEQ002121; Thu, 31 Oct 2024 13:41:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49VDfCmm002118; Thu, 31 Oct 2024 13:41:12 GMT (envelope-from git) Date: Thu, 31 Oct 2024 13:41:12 GMT Message-Id: <202410311341.49VDfCmm002118@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: f84956ab3781 - stable/14 - al_eth: improve TCP LRO List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: f84956ab37819227f488adde81d4cdbba34ce47a Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=f84956ab37819227f488adde81d4cdbba34ce47a commit f84956ab37819227f488adde81d4cdbba34ce47a Author: Michael Tuexen AuthorDate: 2024-09-05 15:35:40 +0000 Commit: Michael Tuexen CommitDate: 2024-10-31 11:19:40 +0000 al_eth: improve TCP LRO Use the appropriate function to flush correctly all entries. The old code does not remove the element from the hash table, only from the active queue. Reviewed by: Peter Lei, rscheff Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D46434 (cherry picked from commit 0b45d36510d8c629fcc49805bc64e5893f4ba63c) --- sys/dev/al_eth/al_eth.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sys/dev/al_eth/al_eth.c b/sys/dev/al_eth/al_eth.c index b4fbf041660b..1b976e7a724c 100644 --- a/sys/dev/al_eth/al_eth.c +++ b/sys/dev/al_eth/al_eth.c @@ -1581,7 +1581,6 @@ al_eth_rx_recv_work(void *arg, int pending) { struct al_eth_ring *rx_ring = arg; struct mbuf *mbuf; - struct lro_entry *queued; unsigned int qid = rx_ring->ring_id; struct al_eth_pkt *hal_pkt = &rx_ring->hal_pkt; uint16_t next_to_clean = rx_ring->next_to_clean; @@ -1672,10 +1671,7 @@ al_eth_rx_recv_work(void *arg, int pending) "%s: not filling rx queue %d\n", __func__, qid); } - while (((queued = LIST_FIRST(&rx_ring->lro.lro_active)) != NULL)) { - LIST_REMOVE(queued, next); - tcp_lro_flush(&rx_ring->lro, queued); - } + tcp_lro_flush_all(&rx_ring->lro); if (napi != 0) { rx_ring->enqueue_is_running = 0;