Re: git: 152382e6613d - main - rc.d/kld: Print the kernel modules being loaded

On 26 Oct 2024, at 20:00, Mark Johnston <markj@FreeBSD.org> wrote:
> 
> The branch main has been updated by markj:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=152382e6613d7998fe6f5233767df54d3fdec329
> 
> commit 152382e6613d7998fe6f5233767df54d3fdec329
> Author:     Mark Felder <feld@FreeBSD.org>
> AuthorDate: 2024-10-26 18:43:46 +0000
> Commit:     Mark Johnston <markj@FreeBSD.org>
> CommitDate: 2024-10-26 18:43:46 +0000
> 
>    rc.d/kld: Print the kernel modules being loaded
> 
>    PR:             282269
>    MFC after:      2 weeks
> ---
> libexec/rc/rc.d/kld | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/libexec/rc/rc.d/kld b/libexec/rc/rc.d/kld
> index d9c45a05f7a6..729416323d6e 100755
> --- a/libexec/rc/rc.d/kld
> +++ b/libexec/rc/rc.d/kld
> @@ -44,10 +44,12 @@ kld_start()
> 
> local _kld
> 
> - echo 'Loading kernel modules:'
> + echo -n 'Loading kernel modules: '
> for _kld in $kld_list ; do
> load_kld -e ${_kld}.ko $_kld
> + echo -n "${_kld} "

This always prints a trailing space, whether the list is empty or not.
Why not drop the space from the first echo and put it as a prefix in
the second instead?

Jess

> done
> + echo
> }
> 
> load_rc_config $name