From nobody Sat Oct 26 19:02:27 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XbTYX1wMxz5b4Xd for ; Sat, 26 Oct 2024 19:02:40 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XbTYX08TZz4tpj for ; Sat, 26 Oct 2024 19:02:40 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-37d4c482844so1953648f8f.0 for ; Sat, 26 Oct 2024 12:02:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729969358; x=1730574158; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DXjvjTGO6e8bbCW3sG9hLD/DfK3rCzu1ESM9INXIvBM=; b=d7kucvf+QGcTSLbw6cnJB4QnviaWtSGJ4auFFlaSREqZFGSvY00Y1Wipd8rAAiVuUz PNmipgL+2dxo7cshiIj6uHzHGlVYbFnE059Rp9worNrorodmGOjxamIsyiaamEIfk+nc 48tAi2CYPRtpkW6rodL3WRpH0672oyc06F8SBPCTgudoacHe8LWfnryVcj/TO+La0GZ4 Ff8WNjUDCeQkUnSDXkj3psA0eD9ps5X45GIVu1mu8gsxe2FzyCYagr5fO8Urr3/O13iY ybQcKrNxnDeE1gdxBsvt4lc0ouDeqllad+fl+bXrYzyNb465g5c86uJviFgoturaIAlK RLMw== X-Forwarded-Encrypted: i=1; AJvYcCWfzhfS/gG1HMK358BGVom8c5P6pwaDJdN3EnoY1e2VyGiRkNP915vblvVb/ePQdItJWRmRf1B9mrCVa+pp5+XBloed@freebsd.org X-Gm-Message-State: AOJu0YxA7KZtNnfekWEQLpfQUSpLe/VqpmNLBVrM0cWCLA+iP4Rj9bRl MefsPmRtd9IcSRS7vVccXp8ktb7ynqrc0vg8UwKUrMvtF1Hcmxrq0td//rgFnMs= X-Google-Smtp-Source: AGHT+IEul2guVjnkvrvObst8hDnXFznI44wgVP33njNWDnuHRj+6pxj6U+eT7Z2XwoZ2vtXRTlzDgQ== X-Received: by 2002:a05:6000:11cb:b0:37d:3f81:153e with SMTP id ffacd0b85a97d-380611282d9mr2627149f8f.14.1729969358565; Sat, 26 Oct 2024 12:02:38 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43193573ce2sm55168715e9.10.2024.10.26.12.02.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 26 Oct 2024 12:02:38 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Subject: Re: git: 152382e6613d - main - rc.d/kld: Print the kernel modules being loaded From: Jessica Clarke In-Reply-To: <202410261900.49QJ0cLo037733@gitrepo.freebsd.org> Date: Sat, 26 Oct 2024 20:02:27 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <08AA3DE1-0618-44A0-AE8C-7BDECD2BE933@freebsd.org> References: <202410261900.49QJ0cLo037733@gitrepo.freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.3818.100.11.1.3) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4XbTYX08TZz4tpj X-Spamd-Bar: ---- On 26 Oct 2024, at 20:00, Mark Johnston wrote: >=20 > The branch main has been updated by markj: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D152382e6613d7998fe6f5233767df54d= 3fdec329 >=20 > commit 152382e6613d7998fe6f5233767df54d3fdec329 > Author: Mark Felder > AuthorDate: 2024-10-26 18:43:46 +0000 > Commit: Mark Johnston > CommitDate: 2024-10-26 18:43:46 +0000 >=20 > rc.d/kld: Print the kernel modules being loaded >=20 > PR: 282269 > MFC after: 2 weeks > --- > libexec/rc/rc.d/kld | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/libexec/rc/rc.d/kld b/libexec/rc/rc.d/kld > index d9c45a05f7a6..729416323d6e 100755 > --- a/libexec/rc/rc.d/kld > +++ b/libexec/rc/rc.d/kld > @@ -44,10 +44,12 @@ kld_start() >=20 > local _kld >=20 > - echo 'Loading kernel modules:' > + echo -n 'Loading kernel modules: ' > for _kld in $kld_list ; do > load_kld -e ${_kld}.ko $_kld > + echo -n "${_kld} " This always prints a trailing space, whether the list is empty or not. Why not drop the space from the first echo and put it as a prefix in the second instead? Jess > done > + echo > } >=20 > load_rc_config $name