Re: git: 542f5d56317e - main - igc: Rename 'struct adapter' to 'struct igc_softc'

From: John Baldwin <jhb_at_FreeBSD.org>
Date: Wed, 16 Oct 2024 14:08:41 UTC 
On 10/15/24 14:48, Kevin Bowling wrote:
> On Tue, Oct 15, 2024 at 11:32 AM Gleb Smirnoff <glebius@freebsd.org> wrote:
>>
>>    Kevin,
>>
>> On Mon, Oct 14, 2024 at 01:53:50PM +0000, Kevin Bowling wrote:
>> K> commit 542f5d56317e94676cf19cb9d66207bf9a6b6758
>> K> Author:     Kevin Bowling <kbowling@FreeBSD.org>
>> K> AuthorDate: 2024-10-14 13:29:55 +0000
>> K> Commit:     Kevin Bowling <kbowling@FreeBSD.org>
>> K> CommitDate: 2024-10-14 13:52:31 +0000
>> K>
>> K>     igc: Rename 'struct adapter' to 'struct igc_softc'
>> K>
>> K>     Rename the 'struct adapter' to 'struct igc_softc' to avoid type
>> K>     ambiguity in things like kgdb and make sharing code with e1000 and
>> K>     ixgbe easier.
>>
>> You gonna like these two :)
>>
>> eb0ec0898261dbc58c328c818adcd8e8fe66bf17
>> 219de4f9d87bbac127ef370ab702e54b7f8d4522
> 
> Ha!  Well the change stuck to e1000 and ixgbe through the oldest
> supported branches so I guess we are safe this time around.

I still appreciate the change as cxgbe is stuck with 'struct adapter' since
it's used in code shared with the Linux chelsio driver (so can't easily be
renamed) so disambiguating is helpful regardless.

-- 
John Baldwin