From nobody Wed Oct 16 14:08:41 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XTCVz0kL6z5YZB0; Wed, 16 Oct 2024 14:08:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XTCVz0Hp1z4Nyx; Wed, 16 Oct 2024 14:08:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729087723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ITqBfJhC1I8XsPl7qfwCNxk7R65DGiTbfT6eWHKqJ04=; b=FaYK1ckymMoEpExsHxKGoPNr5Pv+NWiofcHI3B9c8wmKZ5eKsCZ7YkGvuykwsb7bUdS4Ql sTii+GPetgJ9zk0xA0BpVJoP6S38e9yJCrLo5j0mD08CsXgdvw+p/aw4+p1ePo4UH0g3Gk gfL/SHTNHduqC8ai5KvhsL9UUQ1pOsjWRNQqFgbVCoWZwBtqYivrIXTBwNBucvP9G9L5He YJ8HMibF8n1ix0Act6IJ5jgc9UybCxzAb/dtHdmh73zzBhQ1d5HTjTNBEjWR7sH9Yxk2a5 Baku491+NDKtvSPhaOFxLDdOQaO+KSlI/t3Jna7F7J4ZsIrPbwTw2AwUD7GzRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729087723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ITqBfJhC1I8XsPl7qfwCNxk7R65DGiTbfT6eWHKqJ04=; b=vOwO9SUe9zGZG7Mxb/pwXZBlM60aLnIIjItDzBC9f58dU/sj6dRO1YwCutsmNgF/bDSoeF YlGFgo2FeAfbA1Km1a2yY4D3gIeGY12gF9zxIkfOG2kWOGdX0m+cq4iMvAuT76pRqibIAv IUC35Eup1oOXrtIaGPHt0jG9nWqdd60SBxcm3AL1hO3srnFSP14gaqSc8bMowUIlja9zrj EZXLA5PssPfXxaCl3lI5IyiP1EdocxKonJxZyMhekO/S0tLmsXdTpgvMvTZJuShWcqVcyy Ldh5WliCzp8Lh7Xt0347ztmm1saPUUuDSjbB09Waagq0V+d6i0oxF1/ucjE6Sw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729087723; a=rsa-sha256; cv=none; b=ucN630iLzZTlaLVSgGrg5vZqJOjDXJiu1v36OXOjWb4wjFmmNGpC59EOBTvs8VVNp4yIH6 X5H5GelgW9G8hc1NRWALu6TBcVb2naXrExzj5mW5/9Ekbs25tuhenD0243KdZdB5KCH+VM VV3yTeOKaBlLLJUzfYcwqfjmy8zjHhF8viLafgScY33PXUeNTaBAuJqfqN33SqgOtNZXXi kQeE+A9ScxSypU5WWIGJogdCJYQMTuL7WL2yjsgoVeUzJDEC5yn6kNU494ajMyYErYVb+V k+DdjiOr7Umpyzgd3ZPOUKF+v7xQIdz2lfQDeDCL0FHTa3nzwe27pYNPBLEhzg== Received: from [IPV6:2601:5c0:4200:b830:6065:7bd2:5db8:bc5f] (unknown [IPv6:2601:5c0:4200:b830:6065:7bd2:5db8:bc5f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XTCVy4wXFz1RXk; Wed, 16 Oct 2024 14:08:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Wed, 16 Oct 2024 10:08:41 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 542f5d56317e - main - igc: Rename 'struct adapter' to 'struct igc_softc' To: Kevin Bowling , Gleb Smirnoff Cc: Kevin Bowling , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202410141353.49EDroZg024524@gitrepo.freebsd.org> Content-Language: en-US From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/15/24 14:48, Kevin Bowling wrote: > On Tue, Oct 15, 2024 at 11:32 AM Gleb Smirnoff wrote: >> >> Kevin, >> >> On Mon, Oct 14, 2024 at 01:53:50PM +0000, Kevin Bowling wrote: >> K> commit 542f5d56317e94676cf19cb9d66207bf9a6b6758 >> K> Author: Kevin Bowling >> K> AuthorDate: 2024-10-14 13:29:55 +0000 >> K> Commit: Kevin Bowling >> K> CommitDate: 2024-10-14 13:52:31 +0000 >> K> >> K> igc: Rename 'struct adapter' to 'struct igc_softc' >> K> >> K> Rename the 'struct adapter' to 'struct igc_softc' to avoid type >> K> ambiguity in things like kgdb and make sharing code with e1000 and >> K> ixgbe easier. >> >> You gonna like these two :) >> >> eb0ec0898261dbc58c328c818adcd8e8fe66bf17 >> 219de4f9d87bbac127ef370ab702e54b7f8d4522 > > Ha! Well the change stuck to e1000 and ixgbe through the oldest > supported branches so I guess we are safe this time around. I still appreciate the change as cxgbe is stuck with 'struct adapter' since it's used in code shared with the Linux chelsio driver (so can't easily be renamed) so disambiguating is helpful regardless. -- John Baldwin