Re: git: 2851aafe96c1 - main - mlx5 ipsec_offload: ensure that driver does not dereference dead sahindex

In reply to: Konstantin Belousov : "git: 2851aafe96c1 - main - mlx5 ipsec_offload: ensure that driver does not dereference dead sahindex"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Kristof Provost <kp_at_FreeBSD.org>
Date: Thu, 10 Oct 2024 12:25:43 UTC

On 10 Oct 2024, at 12:00, Konstantin Belousov wrote:
> The branch main has been updated by kib:
>
> URL: 
> https://cgit.FreeBSD.org/src/commit/?id=2851aafe96c1e357971f2b331fff837ead20522b
>
> commit 2851aafe96c1e357971f2b331fff837ead20522b
> Author:     Konstantin Belousov <kib@FreeBSD.org>
> AuthorDate: 2024-09-28 23:17:05 +0000
> Commit:     Konstantin Belousov <kib@FreeBSD.org>
> CommitDate: 2024-10-10 09:55:45 +0000
>
>     mlx5 ipsec_offload: ensure that driver does not dereference dead 
> sahindex
>
>     Take the sahtree rlock and check for the DEAD SA state before 
> validating
>     and filling the SA xfrm attributes.
>
>     Sponsored by:   NVidia networking
> ---
I believe this commit breaks LINT-NOIP builds:

	--- kernel ---
	linking kernel
	ld: error: undefined symbol: ipsec_sahtree_rlock
	>>> referenced by mlx5_ipsec.c
	>>>               mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir)
	>>> referenced by mlx5_ipsec.c
	>>>               mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir)

	ld: error: undefined symbol: ipsec_sahtree_runlock
	>>> referenced by mlx5_ipsec.c
	>>>               mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir)
	>>> referenced by mlx5_ipsec.c
	>>>               mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir)
	>>> referenced by mlx5_ipsec.c
	>>>               mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir)
	*** [kernel] Error code 1

Best regards,
Kristof