From nobody Thu Oct 10 12:25:43 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XPTW06vtNz5Yy2n; Thu, 10 Oct 2024 12:25:48 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XPTW0698Wz4F9V; Thu, 10 Oct 2024 12:25:48 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728563148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rjmb7LDOdqBRfpz8Guh2Oif03nEWVx1wuzWnghplaIE=; b=tFAGis0k4z0TXNOQmTRJu4Mf8034sLG0OY1ZZMAMBiuXCFQY7ZtA7MsTkg38HQlx7jikom rPBf4g6csFWBjP1NyGOroFVRqmAWxANZJxy6qQ1q4D6dOKTmlEZjRQDLBfYI6jMnD1Qwy8 Bf9sbIoqLkZDa66Ha47TC4ZSupmEZslk7mIjAE6aJ7ICxEthCG4PfmFrBs/tvjAVR0JYym t1+z/IpHhBnxFDS+D7FEUkERgXnMooc8D0rxf9V+bPogai3ONa5rvIrOnezb2qbz3YSuSg yUIekkfmELHQhC0hn66hzmg8wJDkYesoEkIWMjLEvZ364AT7aUkUQ2vEJ5xw5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728563148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rjmb7LDOdqBRfpz8Guh2Oif03nEWVx1wuzWnghplaIE=; b=tH2t2OpYC0fKOFShNKrftqNikydoK84xozXJFvMyhZiEQRBWMrGex0PXiS5THkHhCRcjt3 LqfFICGKH2yPGpPdkCTgLXq7XwgF+ZAAe1+cHXpdzd23Psg6z9f6ua9ILn8KjEDV0aIMur ydpkPX633WC4NLT0DtG7sCnMOcFny1AyaExwRUW8ChcggS4HVVFiOeEaVN+KSp/d8+B6zS 6UA1U+h1K2UxvpPVptnEKiS/h31qfDimi4FrOM5vXhLMxy2JmXfT6QRHgys6XiY7NHepQ/ l2vTdpDC/iKkAN0nFXuDBbwbUXPATmQvtVJ6s+xFjpzX46WUV7z2LkHkTqbuSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1728563148; a=rsa-sha256; cv=none; b=VS6FPKu/j5oP4D2T3dyWgr8t4yTkdDFkdTVvYtoO0S2vc+NuVFcj/ww3uALE+D0SCnWCUY XDGJ9t0Nap/3vGqD8X4tK1KRrMswfANGoX2EFpFzGX1rcBZV9QjGFNUE0XU6egCQ5pN0UQ mNW+1OY9jX0Cu20Q/ra58GaO+jU4EEwQJKYzSpL4+0dgaL1k6PwQf2v4O+cUrgwdLltuYI li/6q5iwVVGqIYZ8yQi0IJ/WqUgFlik5Ok9kfZ1t3XqIwrdusXEQSv0ppGjsDMWn4uXCP4 hV3UvaNk8akeIkR/QWfVml2Au3xSZMq6iM20A/CN7pCTUmJ2s8pS5qI5A6Bh/Q== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R11" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XPTW045Qlz1c6g; Thu, 10 Oct 2024 12:25:48 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id EAF63BD0A; Thu, 10 Oct 2024 14:25:43 +0200 (CEST) From: Kristof Provost To: Konstantin Belousov Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2851aafe96c1 - main - mlx5 ipsec_offload: ensure that driver does not dereference dead sahindex Date: Thu, 10 Oct 2024 14:25:43 +0200 X-Mailer: MailMate (1.14r5937) Message-ID: <9DD418B6-E346-4ED8-9212-6BD555FB2431@FreeBSD.org> In-Reply-To: <202410101000.49AA07wh039872@gitrepo.freebsd.org> References: <202410101000.49AA07wh039872@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_25357E85-7349-467E-8FED-1670C4B2178C_=" --=_MailMate_25357E85-7349-467E-8FED-1670C4B2178C_= Content-Type: text/plain; format=flowed Content-Transfer-Encoding: quoted-printable On 10 Oct 2024, at 12:00, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3D2851aafe96c1e357971f2b331fff8= 37ead20522b > > commit 2851aafe96c1e357971f2b331fff837ead20522b > Author: Konstantin Belousov > AuthorDate: 2024-09-28 23:17:05 +0000 > Commit: Konstantin Belousov > CommitDate: 2024-10-10 09:55:45 +0000 > > mlx5 ipsec_offload: ensure that driver does not dereference dead = > sahindex > > Take the sahtree rlock and check for the DEAD SA state before = > validating > and filling the SA xfrm attributes. > > Sponsored by: NVidia networking > --- I believe this commit breaks LINT-NOIP builds: --- kernel --- linking kernel ld: error: undefined symbol: ipsec_sahtree_rlock >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) ld: error: undefined symbol: ipsec_sahtree_runlock >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) *** [kernel] Error code 1 Best regards, Kristof --=_MailMate_25357E85-7349-467E-8FED-1670C4B2178C_= Content-Type: text/html Content-Transfer-Encoding: quoted-printable

On 10 Oct 2024, at 12:00, Konstantin Belousov wrote:

The branch main has been updated by= kib:

URL: https://cgit.FreeBSD.org/src/co= mmit/?id=3D2851aafe96c1e357971f2b331fff837ead20522b

commit 2851aafe96c1e357971f2b331fff837ead20522b
Author: Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2024-09-28 23:17:05 +0000
Commit: Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2024-10-10 09:55:45 +0000

mlx5 ipsec_offload: ensure that driver does not deref= erence dead sahindex

Take the sahtree rlock and check for the DEAD SA stat= e before validating
and filling the SA xfrm attributes.

Sponsored by: NVidia networking
---

I believe this commit breaks LINT-NOIP builds:

--=
- kernel ---
linking kernel
ld: error: undefined symbol: ipsec_sahtree_rlock
>>> referenced by mlx5_ipsec.c
>>>               mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir)
>>> referenced by mlx5_ipsec.c
>>>               mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir)

ld: error: undefined symbol: ipsec_sahtree_runlock
>>> referenced by mlx5_ipsec.c
>>>               mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir)
>>> referenced by mlx5_ipsec.c
>>>               mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir)
>>> referenced by mlx5_ipsec.c
>>>               mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir)
*** [kernel] Error code 1

Best regards,
Kristof

--=_MailMate_25357E85-7349-467E-8FED-1670C4B2178C_=--