Re: git: 45d108ee147c - main - pf_route6(): one more __sdt_used annotation
Date: Wed, 27 Nov 2024 15:25:10 UTC
On Wed, Nov 27, 2024 at 04:10:21PM +0100, Kristof Provost wrote: > On 27 Nov 2024, at 15:31, Konstantin Belousov wrote: > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=45d108ee147cc8776a659578da585b31a0ba5643 > > > > commit 45d108ee147cc8776a659578da585b31a0ba5643 > > Author: Konstantin Belousov <kib@FreeBSD.org> > > AuthorDate: 2024-11-27 14:26:53 +0000 > > Commit: Konstantin Belousov <kib@FreeBSD.org> > > CommitDate: 2024-11-27 14:30:52 +0000 > > > > pf_route6(): one more __sdt_used annotation > > Thanks! > > I thought I’d fixed that when you reported the initial problem, but clearly I missed one. > > I wonder if we shouldn’t remove options KDTRACE_HOOKS from at least one kernel config to improve the odds of catching mistakes like this one pre-commit. > >From MINIMAL maybe? Perhaps it should be removed from LINT. Initial idea around it was that LINT should complement options in other kernels configs, I believe.