From nobody Wed Nov 27 15:25:10 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xz3DC6wv1z5fLvt; Wed, 27 Nov 2024 15:25:31 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xz3D83KMYz4gHT; Wed, 27 Nov 2024 15:25:28 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 4ARFPAIf047497; Wed, 27 Nov 2024 17:25:13 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 4ARFPAIf047497 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 4ARFPAfV047496; Wed, 27 Nov 2024 17:25:10 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 27 Nov 2024 17:25:10 +0200 From: Konstantin Belousov To: Kristof Provost Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 45d108ee147c - main - pf_route6(): one more __sdt_used annotation Message-ID: References: <202411271431.4AREVRbs047403@gitrepo.freebsd.org> <5F91DA38-12C0-412C-9430-7632A0BBB763@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5F91DA38-12C0-412C-9430-7632A0BBB763@FreeBSD.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4Xz3D83KMYz4gHT X-Spamd-Bar: ---- On Wed, Nov 27, 2024 at 04:10:21PM +0100, Kristof Provost wrote: > On 27 Nov 2024, at 15:31, Konstantin Belousov wrote: > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=45d108ee147cc8776a659578da585b31a0ba5643 > > > > commit 45d108ee147cc8776a659578da585b31a0ba5643 > > Author: Konstantin Belousov > > AuthorDate: 2024-11-27 14:26:53 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2024-11-27 14:30:52 +0000 > > > > pf_route6(): one more __sdt_used annotation > > Thanks! > > I thought I’d fixed that when you reported the initial problem, but clearly I missed one. > > I wonder if we shouldn’t remove options KDTRACE_HOOKS from at least one kernel config to improve the odds of catching mistakes like this one pre-commit. > >From MINIMAL maybe? Perhaps it should be removed from LINT. Initial idea around it was that LINT should complement options in other kernels configs, I believe.