Re: git: bec000c9c1ef - main - amd64: add a func pointer to tlb shootdown function

On Wed, 5 Jun 2024 09:51:55 -0700
Ryan Libby <rlibby@gmail.com> wrote:

> On Wed, Jun 5, 2024 at 8:49 AM Enji Cooper <yaneurabeya@gmail.com>
> wrote:
> >
> >
> > On Jun 5, 2024, at 5:38 AM, Wei Hu <whu@FreeBSD.org> wrote:
> >
> > The branch main has been updated by whu:
> >
> > URL:
> > https://cgit.FreeBSD.org/src/commit/?id=bec000c9c1ef409989685bb03ff0532907befb4a
> >
> > commit bec000c9c1ef409989685bb03ff0532907befb4a
> > Author:     Souradeep Chakrabarti <schakrabarti@microsoft.com>
> > AuthorDate: 2024-06-05 12:25:05 +0000
> > Commit:     Wei Hu <whu@FreeBSD.org>
> > CommitDate: 2024-06-05 12:25:05 +0000
> >
> >    amd64: add a func pointer to tlb shootdown function
> >
> >    Make the tlb shootdown function as a pointer. By default, it
> > still points to the system function smp_targeted_tlb_shootdown().
> > It allows other implemenations to overwrite in the future.
> >
> >    Reviewed by:    kib
> >    Tested by:      whu
> >    Authored-by:    Souradeep Chakrabarti
> > <schakrabarti@microsoft.com> Co-Authored-by: Erni Sri Satya Vennela
> > <ernis@microsoft.com> MFC after:      1 week
> >    Sponsored by:   Microsoft
> >    Differential Revision:  https://reviews.freebsd.org/D45174
> >
> >
> > This broke the i386 build:
> > https://ci.freebsd.org/job/FreeBSD-main-i386-build/28056/ Cheers,
> > -Enji
> >  
> 
> Should this be touching sys/vm/pmap.h at all?  It seems wholly
> focused on amd64.
> 
> Ryan

Agreed, this should be done in sys/amd64/include/pmap.h .

- Justin