From nobody Wed Jun 05 16:57:52 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VvYYZ3vtlz5LGW4; Wed, 05 Jun 2024 16:57:54 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VvYYZ3KwWz4PXD; Wed, 5 Jun 2024 16:57:54 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717606674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VDwYr6w5gY+dAl8skm9RRvbuTa93dkKjcvAg1X8iL3o=; b=RckaA+XIhfzPU2mZHy5dnNb6UTJMoOo/kzrkGpPLwOxirj1Lx9ZxDBwJo+3ehE9/38BYR9 CG4L5wmuOw7H2NpQvp6JQDbbNEFFDOBShA0xMATyi/w9qFE6ETmqFVL83YnihgT7P1K1qC B9DaM/vR2Q3QV/zPDl6RSbJvFev/8TAH+lfrbRAAmPWTnHXha4WBwc9kcMpBaf2+9/eX4L e53OqAx5V4izzCVgz+dIvTtKZyvghbSctRnWXjVNTiMTHQRVWhOszDPiqAKmsNngg3nN67 2NXow1+7zYoCEYpHAgZc4rutKFS7rQSu8aPy6eJ3QCz0ad60OiqgrdYX9g8zKQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1717606674; a=rsa-sha256; cv=none; b=mypFv87+FpAmjyZcGtNoSX4bhb7Su/6N2bGv1VQuBSsSHAtiYZfC4qD1LXYzFaqmqFKY/8 Rkpt4KK9Jd7j78j8COCwe46hLM5JqNny6u3mfIilN3aLHaB0t3bx7axOEhhBUq6vL9SpSL R3wjB7DIUeXim3S//Oun1YNik3iCbcUTS9CN9MBsdAOYas8qK1GCfiTZ6sc7OTbYMPUV/f kL0ltXtL14fs9fZw74BxbPsv9ah5+lLf5nE+mcH3PC8uYrHJ1jutBRLSgL/X9jp963RbiT /kG8n7/4c/9oZR8r1Huk4oDrtC1DUrBc+NMBLIHNx8Y/yYeIL7mdiN0pmYynig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717606674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VDwYr6w5gY+dAl8skm9RRvbuTa93dkKjcvAg1X8iL3o=; b=dgAgHW8snML7hOPX+4DPUZXp/sABzpv3wZpCtYfG6ZVCUG6HCHC9KaN4jeMDR+Ux/dTiVl mxsKcRTEbUhAhQU4oml9L0wWNHLgERbLAXqonCU1dbjpi9NncLlB9kDA7qOCrAwPWFs1mO EgXRPDTkQ/YxovnMKNu+BvPGAwINnIGFLlpk2CBLep5xK36xUPtG1anVZPftVaNiNF30DI t4JeuVW4rF7bUSQgvt+u4Rt5Bo2L3CCra73pXWJNPTVHDLkgRAOeN0cdCBQnqVWWgRqlIR woAnJCq349dSVhBgytS5q25i4MQ27d9ipYQ/OqaSYSa9m7/OzT+H2eMOU5X9ag== Received: from ralga.knownspace (ip-163-182-7-56.dynamic.fuse.net [163.182.7.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhibbits) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VvYYZ0zXJz117R; Wed, 5 Jun 2024 16:57:54 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Date: Wed, 5 Jun 2024 12:57:52 -0400 From: Justin Hibbits To: Ryan Libby Cc: Enji Cooper , Wei Hu , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: bec000c9c1ef - main - amd64: add a func pointer to tlb shootdown function Message-ID: <20240605125743.5b39005f@ralga.knownspace> In-Reply-To: References: <202406051238.455CcdGB050229@gitrepo.freebsd.org> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; powerpc64le-unknown-linux-gnu) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 5 Jun 2024 09:51:55 -0700 Ryan Libby wrote: > On Wed, Jun 5, 2024 at 8:49=E2=80=AFAM Enji Cooper > wrote: > > > > > > On Jun 5, 2024, at 5:38=E2=80=AFAM, Wei Hu wrote: > > > > The branch main has been updated by whu: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=3Dbec000c9c1ef409989685bb03ff05= 32907befb4a > > > > commit bec000c9c1ef409989685bb03ff0532907befb4a > > Author: Souradeep Chakrabarti > > AuthorDate: 2024-06-05 12:25:05 +0000 > > Commit: Wei Hu > > CommitDate: 2024-06-05 12:25:05 +0000 > > > > amd64: add a func pointer to tlb shootdown function > > > > Make the tlb shootdown function as a pointer. By default, it > > still points to the system function smp_targeted_tlb_shootdown(). > > It allows other implemenations to overwrite in the future. > > > > Reviewed by: kib > > Tested by: whu > > Authored-by: Souradeep Chakrabarti > > Co-Authored-by: Erni Sri Satya Vennela > > MFC after: 1 week > > Sponsored by: Microsoft > > Differential Revision: https://reviews.freebsd.org/D45174 > > > > > > This broke the i386 build: > > https://ci.freebsd.org/job/FreeBSD-main-i386-build/28056/ Cheers, > > -Enji > > =20 >=20 > Should this be touching sys/vm/pmap.h at all? It seems wholly > focused on amd64. >=20 > Ryan Agreed, this should be done in sys/amd64/include/pmap.h . - Justin