Re: git: 2204a4829083 - main - mlx5en: limit reporting eeprom read failure due to unplugged module to verboseboot

From: Drew Gallatin <gallatin_at_fastmail.com>
Date: Wed, 31 Jul 2024 22:31:18 UTC
Thank you!!

Drew

On Tue, Jul 30, 2024, at 11:00 AM, Konstantin Belousov wrote:
> The branch main has been updated by kib:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=2204a4829083bf2a40304ea873d287a5498973d7
> 
> commit 2204a4829083bf2a40304ea873d287a5498973d7
> Author:     Konstantin Belousov <kib@FreeBSD.org>
> AuthorDate: 2024-07-26 21:09:58 +0000
> Commit:     Konstantin Belousov <kib@FreeBSD.org>
> CommitDate: 2024-07-30 15:00:04 +0000
> 
>     mlx5en: limit reporting eeprom read failure due to unplugged module to verboseboot
>     
>     Requested by:   gallatin
>     Sponsored by:   NVIDIA networking
>     MFC after:      1 week
> ---
> sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
> index 791e278daaf8..ccbdf11a1dd5 100644
> --- a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
> +++ b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
> @@ -3687,9 +3687,11 @@ out:
> /* Check if module is present before doing an access */
> module_status = mlx5_query_module_status(priv->mdev, module_num);
> if (module_status != MLX5_MODULE_STATUS_PLUGGED_ENABLED) {
> - mlx5_en_err(ifp,
> -     "Query module %d status: not plugged (%d), eeprom reading is not supported\n",
> -     module_num, module_status);
> + if (bootverbose)
> + mlx5_en_err(ifp,
> +     "Query module %d status: not plugged (%d), "
> +     "eeprom reading is not supported\n",
> +     module_num, module_status);
> error = EINVAL;
> goto err_i2c;
> }
>