From nobody Wed Jul 31 22:31:18 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WZ6Js1JZZz5RTS4; Wed, 31 Jul 2024 22:31:41 +0000 (UTC) (envelope-from gallatin@fastmail.com) Received: from fhigh3-smtp.messagingengine.com (fhigh3-smtp.messagingengine.com [103.168.172.154]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4WZ6Jr3qKPz4rT7; Wed, 31 Jul 2024 22:31:40 +0000 (UTC) (envelope-from gallatin@fastmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=fastmail.com header.s=fm3 header.b=b+3nrmAx; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=b18bfhrL; dmarc=pass (policy=none) header.from=fastmail.com; spf=pass (mx1.freebsd.org: domain of gallatin@fastmail.com designates 103.168.172.154 as permitted sender) smtp.mailfrom=gallatin@fastmail.com Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id E9D61114709E; Wed, 31 Jul 2024 18:31:38 -0400 (EDT) Received: from wimap26 ([10.202.2.86]) by compute1.internal (MEProxy); Wed, 31 Jul 2024 18:31:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1722465098; x=1722551498; bh=BmVuavah/z JbB44Gmm00IrFnkYnKgkZn/JZi8q3riiw=; b=b+3nrmAxs05BafZ7NAiEqeNDS3 JohdTiWjo4sPeQIa9FD/M2cUvjHnfPnjIUghbse3KLcPoEDIGRXHB3dxhjiB3Qh9 ZTsqScXxbxnx/0CUB2NVFjhtiE3kJT4aKjqMItowmOLeZdFjCNzVvcTBJirSWZb4 mWoT9TJRajXSrACYhJIySk6Nh4Xpun2OUjACkt8wXZfpO3nklIm4xYPfuurrAXeJ aWQaCjzFdZpUUzqoKJJLSyZ8v9qqZy4pxWB5WjlDOj1l+w3tHp6v6YQMiygOyo3E vLp/gqtGSN/gSQjJ1mi0y0mIhn8CBdhfAAohhvSupBa+WOD7rWdI7MGBsuEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1722465098; x=1722551498; bh=BmVuavah/zJbB44Gmm00IrFnkYnK gkZn/JZi8q3riiw=; b=b18bfhrLed4nv7tlaQRWUbnvRaO11nbFu8ds90GMkO8o HO971uKWOyx13vWrzfrWOHm78eCUatzAzpG4NgXNibbB4mmOnlIXym8XZlHSYDpA btHn2ZIVqzDUc//sUiblHa/Ul8FcHrSmtGrPbCYVqAWu7Ef3XFVxz8PTwMA1rpn8 7MR+BTRU+mQnljo07WTY/tgrGbMAkj0rcmHsa3VC+zz4nY8wlxD1LLnIl0ul83Z0 SMg+CJ6zEmUSX3r17U5kPVWiZm4iq+vNVjw8QkPJicW7QpUFIkjSRCDH1k6ql0uH zM0gUX4FCxTuMDkVJpS8yKhRGI7Bv5eZ8eiwevy4qQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrjeejgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofggfffhvffkjghfufgtsegrtderre ertddtnecuhfhrohhmpedfffhrvgifucfirghllhgrthhinhdfuceoghgrlhhlrghtihhn sehfrghsthhmrghilhdrtghomheqnecuggftrfgrthhtvghrnhepjefgvdekffeggfffie efgeeigeehfeduffekvddtveevfeehudejgfduuedvgfeinecuffhomhgrihhnpehfrhgv vggsshgurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepghgrlhhlrghtihhnsehfrghsthhmrghilhdrtghomhdpnhgspghrtghpthht oheptd X-ME-Proxy: Feedback-ID: i2f014658:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 67D2019C0069; Wed, 31 Jul 2024 18:31:38 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Date: Wed, 31 Jul 2024 18:31:18 -0400 From: "Drew Gallatin" To: "Konstantin Belousov" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Message-Id: <01e60d3e-6564-4af1-874d-677ce68084a1@app.fastmail.com> In-Reply-To: <202407301500.46UF0r39092391@gitrepo.freebsd.org> References: <202407301500.46UF0r39092391@gitrepo.freebsd.org> Subject: Re: git: 2204a4829083 - main - mlx5en: limit reporting eeprom read failure due to unplugged module to verboseboot Content-Type: multipart/alternative; boundary=85761518925144bf89be2cd1c785142f X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.29 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[fastmail.com,none]; R_DKIM_ALLOW(-0.20)[fastmail.com:s=fm3,messagingengine.com:s=fm3]; R_SPF_ALLOW(-0.20)[+ip4:103.168.172.128/27]; RWL_MAILSPIKE_VERYGOOD(-0.20)[103.168.172.154:from]; RCVD_IN_DNSWL_LOW(-0.10)[103.168.172.154:from]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; XM_UA_NO_VERSION(0.01)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; FREEMAIL_FROM(0.00)[fastmail.com]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[fastmail.com:+,messagingengine.com:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FREEFALL_USER(0.00)[gallatin]; ASN(0.00)[asn:209242, ipnet:103.168.172.0/24, country:US]; FREEMAIL_ENVFROM(0.00)[fastmail.com]; DWL_DNSWL_NONE(0.00)[messagingengine.com:dkim] X-Rspamd-Queue-Id: 4WZ6Jr3qKPz4rT7 --85761518925144bf89be2cd1c785142f Content-Type: text/plain Content-Transfer-Encoding: 7bit Thank you!! Drew On Tue, Jul 30, 2024, at 11:00 AM, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=2204a4829083bf2a40304ea873d287a5498973d7 > > commit 2204a4829083bf2a40304ea873d287a5498973d7 > Author: Konstantin Belousov > AuthorDate: 2024-07-26 21:09:58 +0000 > Commit: Konstantin Belousov > CommitDate: 2024-07-30 15:00:04 +0000 > > mlx5en: limit reporting eeprom read failure due to unplugged module to verboseboot > > Requested by: gallatin > Sponsored by: NVIDIA networking > MFC after: 1 week > --- > sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c > index 791e278daaf8..ccbdf11a1dd5 100644 > --- a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c > +++ b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c > @@ -3687,9 +3687,11 @@ out: > /* Check if module is present before doing an access */ > module_status = mlx5_query_module_status(priv->mdev, module_num); > if (module_status != MLX5_MODULE_STATUS_PLUGGED_ENABLED) { > - mlx5_en_err(ifp, > - "Query module %d status: not plugged (%d), eeprom reading is not supported\n", > - module_num, module_status); > + if (bootverbose) > + mlx5_en_err(ifp, > + "Query module %d status: not plugged (%d), " > + "eeprom reading is not supported\n", > + module_num, module_status); > error = EINVAL; > goto err_i2c; > } > --85761518925144bf89be2cd1c785142f Content-Type: text/html Content-Transfer-Encoding: quoted-printable
Thank you!!
=

Drew

On Tue, Jul = 30, 2024, at 11:00 AM, Konstantin Belousov wrote:
The branch main has been updated = by kib:


commit 2204a4829083bf2a40304ea= 873d287a5498973d7
Author:     Konstant= in Belousov <kib@FreeBSD.org&g= t;
AuthorDate: 2024-07-26 21:09:58 +0000
Com= mit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2024-0= 7-30 15:00:04 +0000

    mlx5= en: limit reporting eeprom read failure due to unplugged module to verbo= seboot
    
  =   Requested by:   gallatin
  &nbs= p; Sponsored by:   NVIDIA networking
  = ;  MFC after:      1 week
--= -
sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/m= lx5/mlx5_en/mlx5_en_main.c
index 791e278daaf8..ccbdf11a1dd= 5 100644
--- a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
+++ b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
@@ -3687,= 9 +3687,11 @@ out:
/* Check if module is present before do= ing an access */
module_status =3D mlx5_query_module_statu= s(priv->mdev, module_num);
if (module_status !=3D MLX5_= MODULE_STATUS_PLUGGED_ENABLED) {
- mlx5_en_err(ifp,
<= /div>
-     "Query module %d status: not plugged (%= d), eeprom reading is not supported\n",
-   &n= bsp; module_num, module_status);
+ if (bootverbose)
<= /div>
+ mlx5_en_err(ifp,
+     "Q= uery module %d status: not plugged (%d), "
+  &nbs= p;  "eeprom reading is not supported\n",
+  &= nbsp;  module_num, module_status);
error =3D EINVAL;<= br>
goto err_i2c;
}

--85761518925144bf89be2cd1c785142f--