git: 1afe4da75d1d - main - pf: allow MLD LR to be sent without state
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 29 Jul 2024 17:42:55 UTC
The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=1afe4da75d1d2acd33b25eea942af28aa41c82c2 commit 1afe4da75d1d2acd33b25eea942af28aa41c82c2 Author: Kristof Provost <kp@FreeBSD.org> AuthorDate: 2024-07-10 12:36:18 +0000 Commit: Kristof Provost <kp@FreeBSD.org> CommitDate: 2024-07-29 17:42:26 +0000 pf: allow MLD LR to be sent without state Change PF behavior to allow MLD Listener Report packets to be sent without needing a previously created state by MLD Listener Query. It wasn't working because: (1) you might not have a previous MLD Listener Query and (2) the addresses of the Query and Report don't match. ok mikeb@, sashan@ MFC after: 1 day Obtained From: OpenBSD, rzalamena <rzalamena@openbsd.org>, 5c526dbdb0f2 Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/pf/pf.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c index 2532980168e1..62d604260713 100644 --- a/sys/netpfil/pf/pf.c +++ b/sys/netpfil/pf/pf.c @@ -1885,8 +1885,15 @@ pf_icmp_mapping(struct pf_pdesc *pd, u_int8_t type, break; case MLD_LISTENER_QUERY: - *icmp_dir = PF_IN; case MLD_LISTENER_REPORT: { + /* + * Listener Report can be sent by clients + * without an associated Listener Query. + * In addition to that, when Report is sent as a + * reply to a Query its source and destination + * address are different. + */ + *icmp_dir = PF_IN; *virtual_type = MLD_LISTENER_QUERY; *virtual_id = 0; break;