From nobody Mon Jul 29 17:42:55 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WXm0c2T75z5Rfh1; Mon, 29 Jul 2024 17:42:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WXm0c0mcTz4Mlh; Mon, 29 Jul 2024 17:42:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722274976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uBIk8/TDBTunPYPnckrwjgdASD4zcUpd1DZsaMPZv5o=; b=Yc7/pOHaWq9Q2ssU0odajLOOcbKVHd7a6+15qu5fAgto98JI2IPFo9uXSDUcdq03HgvDjY CDJv+jNrSFL/+vdj7Yb1Kt6EejHgaNqg78nCVZ4gYKAIMo44I9QiB6N3fdjI9k4Yb1AfLB u1tUAKRg5cfbAm5NkQHYTYC9Zf4YWDRA2L8nF2yUJ/kYB9iTemskb3kvcrbKaD6NWlwrh9 r7be1Z0D6xu6MxBAfZAKfSpEmaMYSPriaAyD/N6uPpi0JLbKHzFeoq2Xhv03VXFGWk8jCE ttNHLvtbygFkIIp2M0UNYjotesj5E9A6j0S6/5pdRAZ78zp7Zfn+byTvMJaHSA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1722274976; a=rsa-sha256; cv=none; b=PywGMHnGSFV8phizU62ws/B3dwnrvULkRC7YJhryagy8//5kJjFNlk80l47ToUwLlV5JQE 7qXAQqHYfPGTT66V+gpAJMAsYNvGbp4+wYdmgRDzoYmFcIXhLN2PgipWagCucqIa8upsVv HY8E3ZZOtXtW+5HGnG1m6l2XGgBg/W9GlJwRVXwhXGsDeduirB/qQF8HTPtXgL7UwmP5v9 MBsYlgBq6yf/bb7BITUNbFr0tHFc5iPYsu+La2igQZXPt7Gur0cqzi8GTKJDbpZ3/JijaL 1fA+QbjccZo1+cZSCK3dw5YQ5YYDGLh2eYgOA/OEbX/0VmyWVMCW2IWGIT9DZg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722274976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uBIk8/TDBTunPYPnckrwjgdASD4zcUpd1DZsaMPZv5o=; b=w26uH3tPd8Hq/ONZ2OYQ2/hwP7B1/lGxQvKZKtHKYY4M/dcWznpfwQew6NpBkCaOF2H7Hr L9zVL4UgDxb4d5z54va2Pot3ndJaf4YYPjZveV8jp/28ffwnqtBVPbu9R96zVkAGs7247v VFM3joP1Oj26sAuPxDpLp7Zbf9VxVojGCgUEthm/OjqJ1Dh+2MoFCKbwBdDLUNuN0Pa8Es hx4VMUbNfm+5Vqc4P/wvOI28OT9rNxCo5vMFjDOGBGnba3Gu5fYWbDdtsMiQozMX7L6x7j AcyakIBeTEFS5wbhmv6iPVLjO58RVtHKCGAYsIdvxkMCTc/PVGudF3LURc2kkQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WXm0c0NQ2zjyV; Mon, 29 Jul 2024 17:42:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 46THgtDu023284; Mon, 29 Jul 2024 17:42:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 46THgt4T023281; Mon, 29 Jul 2024 17:42:55 GMT (envelope-from git) Date: Mon, 29 Jul 2024 17:42:55 GMT Message-Id: <202407291742.46THgt4T023281@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 1afe4da75d1d - main - pf: allow MLD LR to be sent without state List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1afe4da75d1d2acd33b25eea942af28aa41c82c2 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=1afe4da75d1d2acd33b25eea942af28aa41c82c2 commit 1afe4da75d1d2acd33b25eea942af28aa41c82c2 Author: Kristof Provost AuthorDate: 2024-07-10 12:36:18 +0000 Commit: Kristof Provost CommitDate: 2024-07-29 17:42:26 +0000 pf: allow MLD LR to be sent without state Change PF behavior to allow MLD Listener Report packets to be sent without needing a previously created state by MLD Listener Query. It wasn't working because: (1) you might not have a previous MLD Listener Query and (2) the addresses of the Query and Report don't match. ok mikeb@, sashan@ MFC after: 1 day Obtained From: OpenBSD, rzalamena , 5c526dbdb0f2 Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/pf/pf.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c index 2532980168e1..62d604260713 100644 --- a/sys/netpfil/pf/pf.c +++ b/sys/netpfil/pf/pf.c @@ -1885,8 +1885,15 @@ pf_icmp_mapping(struct pf_pdesc *pd, u_int8_t type, break; case MLD_LISTENER_QUERY: - *icmp_dir = PF_IN; case MLD_LISTENER_REPORT: { + /* + * Listener Report can be sent by clients + * without an associated Listener Query. + * In addition to that, when Report is sent as a + * reply to a Query its source and destination + * address are different. + */ + *icmp_dir = PF_IN; *virtual_type = MLD_LISTENER_QUERY; *virtual_id = 0; break;