Re: git: 56816e687557 - main - riscv: Eswin hwreset support added.

On Tue, Dec 17, 2024, 10:36 AM Ruslan Bukin <br@freebsd.org> wrote:

> On Tue, Dec 17, 2024 at 02:39:00PM +0000, Jessica Clarke wrote:
> > On 17 Dec 2024, at 11:47, Ruslan Bukin <br@FreeBSD.org> wrote:
> > >
> > > The branch main has been updated by br:
> > >
> > > URL:
> https://cgit.FreeBSD.org/src/commit/?id=56816e68755725371ac89dc5aa882fdce46605a5
> > >
> > > commit 56816e68755725371ac89dc5aa882fdce46605a5
> > > Author:     Ruslan Bukin <br@FreeBSD.org>
> > > AuthorDate: 2024-12-17 11:35:08 +0000
> > > Commit:     Ruslan Bukin <br@FreeBSD.org>
> > > CommitDate: 2024-12-17 11:46:10 +0000
> > >
> > >    riscv: Eswin hwreset support added.
> > >
> > >    Add reset controller driver for Eswin EIC7700.
> > >
> > >    This one has two reset cells in FDT, which is unusual, so provide a
> > >    custom hwreset_map method.
> > >
> > >    Tested on SiFive Premier P550.
> > >
> > >    Reviewed by: mhorne, jrtc27
> >
> > I gave one review comment, I didn’t get to approving it. Are you
> > writing these manually rather than using (git-)arc?...
> >
> > Jess
> >
>
> I apologize. I'm using git arc. The comment you left resulted to a
> positive impact on the code so I decided to indicate you as well,
> despite you did not press Accept.
>

Discussed-with: I think is the trailer to use for this situation where
input was given without final approval.

Warner

>