From nobody Tue Dec 17 17:47:58 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YCPRj6s0xz5hVYQ for ; Tue, 17 Dec 2024 17:48:17 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YCPRj4S5Pz4HH4 for ; Tue, 17 Dec 2024 17:48:17 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-215770613dbso38250175ad.2 for ; Tue, 17 Dec 2024 09:48:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1734457691; x=1735062491; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8ITd7o23SvKngkhgOgh5BeOSkEQxlwB9xe259U6gJgM=; b=Z4Jrp/ksuWsya48mx9d/r3zXV6kN4vUQ7Ip2l/yPtk77+JA/stYEhbY4CeyiUbCEWC bM63Irp/wKje3yRhp2hA/E+eozUHzv8F8czDXKWTYwIIS5zyMa490c/oVvRJhdvWPknm l/jH/I+yC9nhXM4dymQf+FpqfyL8wMlk1n8/Xtvgzt2/wq2Htt1d6wR2n7z/BQhEBrm4 RM3X+ui61NLeH9zVatPItcTO/S+E+6mjv5oBWj+/D7KEOSWgu2yuukvYbRTm4qGUvYdL NVN91TB9M51XbQ88U44lh7YencesNaqCsIgkJX9Gd/GMp4E64jujoC6k3yTV/uHbPeBH zEkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734457691; x=1735062491; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8ITd7o23SvKngkhgOgh5BeOSkEQxlwB9xe259U6gJgM=; b=t59adGBHooHoFkf1qNq97aBvrjwBIpQrjZEQtWWlRJIVgvaUhDz8NfBeoQecMKltYz kgIbzpFscbtHdMw9oxf0ZPchJT7YTbBU+PjYcUsgyva5NHj9EARWVPCCBVOF3SjYYSqO SuE6hy3B9NEeXJmHM1kb5kzq8tLIVq3G7Zk3FDECf9cuYuLhBDqHWQKx8bTYLHjN2gHR hEd1+3M5OTOFY/gUyo0KhuhLdaLCXc0NnA461AqOPRN8r65dxf2EJBSdQnx0X1yZXGDs 0eam0ZprDz6dCFKq1swLALXbUE2s+TwH4j6rVIZdufJtj5CmQtCIg4v6LaKrqICxTZgt BmhQ== X-Forwarded-Encrypted: i=1; AJvYcCVFX1nCl6E0ccdbGEGmZMG6ZlnzLWF2TOJ4Ydsz4Ok8zU0e2AV3sWOTcft5Z5znV/lUL1m6KYHSe90Dhc9s4oJlulPb@freebsd.org X-Gm-Message-State: AOJu0YzlI5il+1bKx/Ni7orGMDviL89Nn+e39dyT8KQzJwWvaaVVGAI4 MzfIBxakVlfo1QU74GBB8/pZgo7H0s+29/rush+a9dDwFxHB6fqwGaXBQV9xU+/GQwZdKOUAh5K TbnDaRy45cjbtjjZe9RHUfGBoHv3dpLACVJ7QLcOOkWbYPV81e2M= X-Gm-Gg: ASbGncseCC+ts1KSQSRCLZ11lWL0lySOjgLLRl8PuytrzMxtxiolbi/44Iik0868cdQ R9XdZrjDziOYdJXrYpfTSKRqaPCygJGRy94OwV0nksm4I95NJNCnbghNbVFS7FqJyk3EQ X-Google-Smtp-Source: AGHT+IG5Pi87kwT883XlnpGGgA6FHkS6WRrIxvnUiK47pUC8XZxABxq1DriV4XO0g/QVyHvhSE502glz4pez1KZrvRk= X-Received: by 2002:a17:90b:2652:b0:2ee:b666:d14a with SMTP id 98e67ed59e1d1-2f28fd6a6a8mr28815406a91.17.1734457690797; Tue, 17 Dec 2024 09:48:10 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202412171147.4BHBlAs7010565@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 17 Dec 2024 10:47:58 -0700 Message-ID: Subject: Re: git: 56816e687557 - main - riscv: Eswin hwreset support added. To: Ruslan Bukin Cc: Jessica Clarke , src-committers , "" , "" Content-Type: multipart/alternative; boundary="00000000000089dbb506297ae67b" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4YCPRj4S5Pz4HH4 X-Spamd-Bar: ---- --00000000000089dbb506297ae67b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 17, 2024, 10:36=E2=80=AFAM Ruslan Bukin wrote: > On Tue, Dec 17, 2024 at 02:39:00PM +0000, Jessica Clarke wrote: > > On 17 Dec 2024, at 11:47, Ruslan Bukin wrote: > > > > > > The branch main has been updated by br: > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D56816e68755725371ac89dc5aa882fd= ce46605a5 > > > > > > commit 56816e68755725371ac89dc5aa882fdce46605a5 > > > Author: Ruslan Bukin > > > AuthorDate: 2024-12-17 11:35:08 +0000 > > > Commit: Ruslan Bukin > > > CommitDate: 2024-12-17 11:46:10 +0000 > > > > > > riscv: Eswin hwreset support added. > > > > > > Add reset controller driver for Eswin EIC7700. > > > > > > This one has two reset cells in FDT, which is unusual, so provide = a > > > custom hwreset_map method. > > > > > > Tested on SiFive Premier P550. > > > > > > Reviewed by: mhorne, jrtc27 > > > > I gave one review comment, I didn=E2=80=99t get to approving it. Are yo= u > > writing these manually rather than using (git-)arc?... > > > > Jess > > > > I apologize. I'm using git arc. The comment you left resulted to a > positive impact on the code so I decided to indicate you as well, > despite you did not press Accept. > Discussed-with: I think is the trailer to use for this situation where input was given without final approval. Warner > --00000000000089dbb506297ae67b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Dec 17, 2024, 10:36=E2= =80=AFAM Ruslan Bukin <br@freebsd.org<= /a>> wrote:
On Tue, Dec 17, 2024= at 02:39:00PM +0000, Jessica Clarke wrote:
> On 17 Dec 2024, at 11:47, Ruslan Bukin <br@FreeBSD.org> wrote: > >
> > The branch main has been updated by br:
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=3D56816e68755725371ac89dc5a= a882fdce46605a5
> >
> > commit 56816e68755725371ac89dc5aa882fdce46605a5
> > Author:=C2=A0 =C2=A0 =C2=A0Ruslan Bukin <br@FreeBSD.org> > > AuthorDate: 2024-12-17 11:35:08 +0000
> > Commit:=C2=A0 =C2=A0 =C2=A0Ruslan Bukin <br@FreeBSD.org> > > CommitDate: 2024-12-17 11:46:10 +0000
> >
> >=C2=A0 =C2=A0 riscv: Eswin hwreset support added.
> >
> >=C2=A0 =C2=A0 Add reset controller driver for Eswin EIC7700.
> >
> >=C2=A0 =C2=A0 This one has two reset cells in FDT, which is unusua= l, so provide a
> >=C2=A0 =C2=A0 custom hwreset_map method.
> >
> >=C2=A0 =C2=A0 Tested on SiFive Premier P550.
> >
> >=C2=A0 =C2=A0 Reviewed by: mhorne, jrtc27
>
> I gave one review comment, I didn=E2=80=99t get to approving it. Are y= ou
> writing these manually rather than using (git-)arc?...
>
> Jess
>

I apologize. I'm using git arc. The comment you left resulted to a
positive impact on the code so I decided to indicate you as well,
despite you did not press Accept.

Discussed-with: I think is the trailer to = use for this situation where input was given without final approval.=C2=A0<= /div>

Warner=C2=A0
--00000000000089dbb506297ae67b--