Re: git: ac83063d37e5 - main - bcm2838_xhci: add module

> On 10 Apr 2024, at 04:22, Warner Losh <imp@FreeBSD.org> wrote:
> 
> The branch main has been updated by imp:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=ac83063d37e5e92ad048cc4ed958654c02103f74
> 
> commit ac83063d37e5e92ad048cc4ed958654c02103f74
> Author:     Lexi Winter <lexi@le-Fay.ORG>
> AuthorDate: 2024-04-10 03:11:36 +0000
> Commit:     Warner Losh <imp@FreeBSD.org>
> CommitDate: 2024-04-10 03:11:39 +0000
> 
>    bcm2838_xhci: add module
> 
>    bcm2838_xhci(4) is a shim for the XHCI controller on the Raspberry Pi 4B
>    SoC.  It loads the controller's firmware before passing control to the
>    normal xhci(4) driver.
> 
>    When xhci(4) is built as a module (and not in the kernel), bcm2838_xhci
>    is not built at all and the RPi4's XHCI controller won't attach due to
>    missing firmware.
> 
>    To fix this, build a new module, bcm2838_xhci.ko, which depends on
>    xhci.ko.  For the dependency to work correctly, also modify xhci to
>    provide the 'xhci' module in addition to the 'xhci_pci' module it
>    already provided.
> 
>    Since bcm2838_xhci is specific to a quirk of the RPi4 SoC, only build
>    the module for AArch64.

I think this broke GENERIC-ACPI kernel. The bcm2838_xhci driver is FDT only.

Andrew