From nobody Thu Apr 11 10:09:47 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VFb6Q6RDRz5H8SQ for ; Thu, 11 Apr 2024 10:10:06 +0000 (UTC) (envelope-from bounce.v7odq7bf30=dbxfmsgoyljj=pya5rmvi9y@em790814.fubar.geek.nz) Received: from e3i19.smtp2go.com (e3i19.smtp2go.com [158.120.84.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4VFb6Q3vN4z4qCP for ; Thu, 11 Apr 2024 10:10:06 +0000 (UTC) (envelope-from bounce.v7odq7bf30=dbxfmsgoyljj=pya5rmvi9y@em790814.fubar.geek.nz) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=smtpservice.net header.s=a1-4 header.b=nu4qYcKy; dkim=pass header.d=fubar.geek.nz header.s=s790814 header.b="aUvHGf/t"; dmarc=pass (policy=none) header.from=fubar.geek.nz; spf=pass (mx1.freebsd.org: domain of "bounce.v7odq7bf30=dbxfmsgoyljj=pya5rmvi9y@em790814.fubar.geek.nz" designates 158.120.84.19 as permitted sender) smtp.mailfrom="bounce.v7odq7bf30=dbxfmsgoyljj=pya5rmvi9y@em790814.fubar.geek.nz" Received: from [10.99.243.232] (helo=morbo.fubar.geek.nz) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96.1-S2G) (envelope-from ) id 1rurNX-9EHbge-1Y; Thu, 11 Apr 2024 10:09:59 +0000 Received: from smtpclient.apple (92.40.168.11.threembb.co.uk [92.40.168.11]) by morbo.fubar.geek.nz (Postfix) with ESMTPSA id 5882618818; Thu, 11 Apr 2024 10:09:57 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: dev-commits-src-all+owner@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.100.2.1.4\)) Subject: Re: git: ac83063d37e5 - main - bcm2838_xhci: add module From: Andrew Turner In-Reply-To: <202404100322.43A3MTXZ087267@gitrepo.freebsd.org> Date: Thu, 11 Apr 2024 11:09:47 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202404100322.43A3MTXZ087267@gitrepo.freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3774.100.2.1.4) X-smtpcorp-track: 1rIrNb9EHPg-1Y.F2P2G6fpR5FTs DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smtpservice.net; i=@smtpservice.net; q=dns/txt; s=a1-4; t=1712830200; h=feedback-id : x-smtpcorp-track : date : message-id : to : subject : from : reply-to : sender : list-unsubscribe; bh=WV4AnEMaQNLzYvFYOrSQ+AbdCGd1HhCI9yvn2++59YY=; b=nu4qYcKy3nH2CrnaDCRlb60IDfqypK7976rcxFnsp9vCZUJ2dEt6r0kUb5zCh37P1O+VQ +O4UNoJ4JywYveQi3N/JKsaT49L9CbGHqywTdr4FlQHwpTpb7UQanN/4CYx23nonAauzCgR 0YOQsuxXw8LHyWaiY+Mcnnv0f7JFxWRBugkOjATj7Rf/1CGMSZqpLnI3KoCjAPDGQ18KVb/ f5Y3akDQqYKt3gVXvvhlUVOo6xJpUglFa6VE4Zyor0gWmWmdOw2YaRxbT3IDDxpyZ8+XsPq gLQ/XO/60xbixY8zqh4xjL3eG+rgdq47KrDVz7iXIgS3o6RzNVjR/Ot/7oXQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fubar.geek.nz; i=@fubar.geek.nz; q=dns/txt; s=s790814; t=1712830200; h=from : subject : to : message-id : date; bh=WV4AnEMaQNLzYvFYOrSQ+AbdCGd1HhCI9yvn2++59YY=; b=aUvHGf/tgGcDB+YSBdb1Gaga3JcJ9/aMYWxZ7U1RcHbaO2QXcTUtNHc4AptkJw2f6695Q ngQaxpFau3JinxTnjWVVbaB00FJ0bM7oapbjYFc/wN8I8PYEMO/UnoOphkmoOqYZnow1Uzx wz6zYhEQU/2NmGtZ3ggvj+t40DztpsYCZtOMBIKDCl75zJbpZl1EhgmEFna660TipNxBhJ4 3Epr5L6nlxny8Ux4fKTr85+M6PJPpj+/0Z/arSIUf+4vxUFLpiLgjKywkYIGbrNgSSKpGVB vo0vrVnRJmoW+n6ytWXxmTjxf/TZGR87hAoSusm+dOyfIe2QGLut0e2/B5kA== X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.40 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; DMARC_POLICY_ALLOW(-0.50)[fubar.geek.nz,none]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[andrew@fubar.geek.nz,bounce.v7odq7bf30=dbxfmsgoyljj=pya5rmvi9y@em790814.fubar.geek.nz]; RWL_MAILSPIKE_VERYGOOD(-0.20)[158.120.84.19:from]; R_DKIM_ALLOW(-0.20)[smtpservice.net:s=a1-4,fubar.geek.nz:s=s790814]; R_SPF_ALLOW(-0.20)[+ip4:158.120.80.0/21:c]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:23352, ipnet:158.120.84.0/22, country:US]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[andrew@fubar.geek.nz,bounce.v7odq7bf30=dbxfmsgoyljj=pya5rmvi9y@em790814.fubar.geek.nz]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[smtpservice.net:+,fubar.geek.nz:+] X-Rspamd-Queue-Id: 4VFb6Q3vN4z4qCP > On 10 Apr 2024, at 04:22, Warner Losh wrote: >=20 > The branch main has been updated by imp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dac83063d37e5e92ad048cc4ed958654c= 02103f74 >=20 > commit ac83063d37e5e92ad048cc4ed958654c02103f74 > Author: Lexi Winter > AuthorDate: 2024-04-10 03:11:36 +0000 > Commit: Warner Losh > CommitDate: 2024-04-10 03:11:39 +0000 >=20 > bcm2838_xhci: add module >=20 > bcm2838_xhci(4) is a shim for the XHCI controller on the Raspberry = Pi 4B > SoC. It loads the controller's firmware before passing control to = the > normal xhci(4) driver. >=20 > When xhci(4) is built as a module (and not in the kernel), = bcm2838_xhci > is not built at all and the RPi4's XHCI controller won't attach due = to > missing firmware. >=20 > To fix this, build a new module, bcm2838_xhci.ko, which depends on > xhci.ko. For the dependency to work correctly, also modify xhci to > provide the 'xhci' module in addition to the 'xhci_pci' module it > already provided. >=20 > Since bcm2838_xhci is specific to a quirk of the RPi4 SoC, only = build > the module for AArch64. I think this broke GENERIC-ACPI kernel. The bcm2838_xhci driver is FDT = only. Andrew=