Re: git: 816129210ad4 - main - tests: Don't recurse into sys/compat32

From: Kyle Evans <kevans_at_freebsd.org>
Date: Tue, 23 May 2023 01:38:12 UTC 
On Mon, May 15, 2023 at 8:09 PM Jessica Clarke <jrtc27@freebsd.org> wrote:
>
> The branch main has been updated by jrtc27:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=816129210ad4f951059db2d942b8213ffe0a0f89
>
> commit 816129210ad4f951059db2d942b8213ffe0a0f89
> Author:     Jessica Clarke <jrtc27@FreeBSD.org>
> AuthorDate: 2023-05-16 01:06:34 +0000
> Commit:     Jessica Clarke <jrtc27@FreeBSD.org>
> CommitDate: 2023-05-16 01:06:34 +0000
>
>     tests: Don't recurse into sys/compat32
>
>     Stubbing out the whole file means it has no targets, so recursive makes
>     fail with "don't know how to make X". We could fix that, but because the
>     level above is adding it to TESTS_SUBDIRS it'll generate an include line
>     for the subdirectory in its Kyuafile, which won't work (the problem that
>     was previously seen on non-aarch64 in CI). Thus we really need to not
>     even add it to TESTS_SUBDIRS in the first place.
>
>     Reported by:    Dan Mack <mack@macktronics.com>
>     Fixes:          28f66935d400 ("tests: Disable sys/compat32 and sys/compat32/aarch64 tests")

Hi,

For anyone interested, I posted a review for this part of the problem
here: https://reviews.freebsd.org/D40224

This particular breakage wouldn't have happened if the flattening was
done in a less fragile way to begin with.

Thanks for helping me cover this up and discussing solutions, by the way-

Thanks,

Kyle Evans