From nobody Tue May 23 01:38:12 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QQH5W6xTRz4CkNd; Tue, 23 May 2023 01:38:23 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QQH5W6S0hz3MVn; Tue, 23 May 2023 01:38:23 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684805903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OPE60WgJVdur+F4zkipq0fw2fnMAwaqVRCCIY1u83pE=; b=i4X0q1rvsgXmtNqCJxjnRr41yzLwWBrazsWwzXlthU2wt3uA6UyEoHlM54TU4ZkOZFQ72G /JJClRjJ3Apb6kNs/aZNw2Jg+d6JtucsQukx/m6e+jmV+Kip2fb10YXaPvT/EbtkEyZvF5 ELzyWNVwVsK6d2jep10jPl7J5NplH7G1sPLrzu4eECurb8HpgNBqpnVz8lrG3cJdndC9To vvswrPjKy2hffZArBGQqPNmtJPAIshyFiecCYRDFbjDF/AUXUkwq9vL+IURzbnLjQ4GO2+ QWNmXJxk0TKJHbV0udRc1mRSi48Pd2as1nIIBDm4a39QNT0Wcz2WkkZNmZsLJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684805903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OPE60WgJVdur+F4zkipq0fw2fnMAwaqVRCCIY1u83pE=; b=MBeP6ASfOdRFvxUi4+gp/1iKj4SdLZ1TteZACSQ3dB1ProkqI5BxlLi8qJaWLFvH9hkk5s oWaAYI/O7tsGzujX9Pi2ZvkOKUItfKX4tpre8SAs4itKxXvpCPhRv49P8UeyN3lhb38O2h t6w+2eorov3h7ZUneR+sNQQTd+QsfmybH56lQ7ZQuCBPWjNXBHq9/b3rTml/mtea1cJ82L ZNit0EGP7AS+J8Vs+Au9dY1NkJSbyPR3I1cXptd3lnkfTml4fd/pOWPSAVrMjU+Bny1ujE 4dj7fE5dhH+I2leQqLbVuBhpZPI9BwUg1Hx7MltqFnpuBi1Za1/l7LNtK8xIWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684805903; a=rsa-sha256; cv=none; b=j6SUmK1dFLaTpOFDCt78u28j1pNFEyzIsiy9ikWQjq1mgNSWLCq8DJEfSWi+B1Po1u2cCo meFL0uwGTpkrNqs3tMwnzWbZjLI2I7r3610nKaPIYnS9Y3QXtdERid4U+1t94laxXSH7Wn hlo5cgrv3kYFhl3XN0UFc15fKDV/HqxkNy/mkKeSjxY6XB9PUVorklXhveEh/E5I/a+kz9 OtEv/yThn1N2JqXV9n/3GB4yNvkcxkUfegQLVLCM2ZQU6L1OQ8zdLI9fP30gWc2yNoN4Vp 56fS4n4GhIeGH8kr6i/zDfBXeGat5+L9wC92iM0lNnNCDUMMlzV9ebSE3DdqbQ== Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QQH5W5P8vzKGv; Tue, 23 May 2023 01:38:23 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-75764d20db3so597093685a.2; Mon, 22 May 2023 18:38:23 -0700 (PDT) X-Gm-Message-State: AC+VfDyJgVko0YRsOJviFCXJZhwQQwyJNAKpNMiDsSuwWS9ITEESKTet Pjmu9ZZtHdEwZSRy3rzIrERc97phmnHXQwaq9PM= X-Google-Smtp-Source: ACHHUZ5HHqUu9O3NvoB2jhNMsn/KHNKUZIEfnEOeuAfDvqlYn4HxL1x8MQJIFN7cMieLMv9SSk81cfwldZK/am8yJrk= X-Received: by 2002:a05:620a:3a45:b0:75b:23a1:481 with SMTP id sk5-20020a05620a3a4500b0075b23a10481mr2628957qkn.71.1684805902853; Mon, 22 May 2023 18:38:22 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202305160109.34G19Zs0095589@gitrepo.freebsd.org> In-Reply-To: <202305160109.34G19Zs0095589@gitrepo.freebsd.org> From: Kyle Evans Date: Mon, 22 May 2023 20:38:12 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 816129210ad4 - main - tests: Don't recurse into sys/compat32 To: Jessica Clarke Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-ThisMailContainsUnwantedMimeParts: N On Mon, May 15, 2023 at 8:09=E2=80=AFPM Jessica Clarke = wrote: > > The branch main has been updated by jrtc27: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D816129210ad4f951059db2d942= b8213ffe0a0f89 > > commit 816129210ad4f951059db2d942b8213ffe0a0f89 > Author: Jessica Clarke > AuthorDate: 2023-05-16 01:06:34 +0000 > Commit: Jessica Clarke > CommitDate: 2023-05-16 01:06:34 +0000 > > tests: Don't recurse into sys/compat32 > > Stubbing out the whole file means it has no targets, so recursive mak= es > fail with "don't know how to make X". We could fix that, but because = the > level above is adding it to TESTS_SUBDIRS it'll generate an include l= ine > for the subdirectory in its Kyuafile, which won't work (the problem t= hat > was previously seen on non-aarch64 in CI). Thus we really need to not > even add it to TESTS_SUBDIRS in the first place. > > Reported by: Dan Mack > Fixes: 28f66935d400 ("tests: Disable sys/compat32 and sys/co= mpat32/aarch64 tests") Hi, For anyone interested, I posted a review for this part of the problem here: https://reviews.freebsd.org/D40224 This particular breakage wouldn't have happened if the flattening was done in a less fragile way to begin with. Thanks for helping me cover this up and discussing solutions, by the way- Thanks, Kyle Evans