Re: git: 15e7fa83ef3c - main - arm64: Hyper-V: Add vPCI and Mellanox driver modules into build

From: Jessica Clarke <jrtc27_at_freebsd.org>
Date: Tue, 14 Mar 2023 07:54:48 UTC
On 14 Mar 2023, at 07:46, Emmanuel Vadot <manu@bidouilliste.com> wrote:
> 
> On Tue, 14 Mar 2023 06:59:00 +0000
> Jessica Clarke <jrtc27@freebsd.org> wrote:
> 
>> On 14 Mar 2023, at 06:56, Wei Hu <weh@microsoft.com> wrote:
>>> 
>>>>>>>> +
>>>>>>>> +options 	COMPAT_LINUXKPI
>>>>>>>> +device		xz
>>>>>>>> +
>>>>>>>> +device		mlx5
>>>>>>>> +device		mlxfw
>>>>>>>> +device		mlx5en
>>>>>>>> +options 	RATELIMIT
>>>> 
>>>> As pointed out on IRC, no other kernel config, aside from LINT ones, enables
>>>> this. Therefore this seems pretty dubious to add; why does
>>>> arm64 need it whilst amd64, which does include Mellanox drivers in its
>>>> GENERIC, doesn't need it?
>>>> 
>>> 
>>> How about moving these to std.nvidia? Does it look better to you?
>> 
>> They?re not part of an Nvidia SoC.
>> 
>> Anyway, I already moved them to a new std.azure.
>> 
>> Jess
>> 
> 
> Why do we need them in GENERIC anyway ?
> We have modules already built, we have devmatch, if mlx driver don't
> autoload we should just fix that.

I guess for the same reasons as https://reviews.freebsd.org/D28469?

Jess

> -- 
> Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>