From nobody Tue Mar 14 07:54:48 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PbQmC1JJQz3xtnJ for ; Tue, 14 Mar 2023 07:54:51 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PbQmB6RlPz3CMq for ; Tue, 14 Mar 2023 07:54:50 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f46.google.com with SMTP id i9so4401613wrp.3 for ; Tue, 14 Mar 2023 00:54:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678780489; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=trXyPLKkcdskPO6ULia4VHu3YwCqKBW0knzULv+SmYo=; b=Ibi6OQZZhTH5BcwRK8wuPrjdiwQS7xdF5aqr/3L0gRO4tPUtbfyaF8MISQP09fu6kl +AVdTqZll9dBjhs/+/LWQwkj7uynlbaJavSLpTXdikI9HlZvKH9VibWFi9Fht8D3mIbH H4N6KlVbzPABam1fPZq5OSpe+xEkhLpngqZT4+rvyzp9Xqv4NjE7FMYc0VmIu7eC0Igf Det3YDp0ss77NVjVzrzLXpIxqvh4vV8x4i/OFmMcol8jcfQTEP0ISUL/iTNjY/OaUe9q KQgDWGn/ZBSg9A1LtpEaSDx+dlTjDAt6OrQXKHZllxgXv2XcfR/LtdGEqPmLgDyThK+2 qvKw== X-Gm-Message-State: AO0yUKUu6qpCfJ2YPcsf3yadkKvgtRMSuSv2uVS1Hl3ASqg9LES8T2dy MS+6HvUM9hd/hEFkpi3bTqypHw== X-Google-Smtp-Source: AK7set8Cg0aA+eHbhULQRBFUjuXo/Q6ox6fe8LInGJqBC67s1eH8IrUkAYxy/4IKB4EhX5hHvi9eXw== X-Received: by 2002:a5d:604a:0:b0:2c9:e996:8275 with SMTP id j10-20020a5d604a000000b002c9e9968275mr22913169wrt.13.1678780489469; Tue, 14 Mar 2023 00:54:49 -0700 (PDT) Received: from smtpclient.apple (global-5-144.n-2.net.cam.ac.uk. [131.111.5.144]) by smtp.gmail.com with ESMTPSA id j15-20020adff00f000000b002cea9d931e6sm1368912wro.78.2023.03.14.00.54.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Mar 2023 00:54:49 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 15e7fa83ef3c - main - arm64: Hyper-V: Add vPCI and Mellanox driver modules into build From: Jessica Clarke In-Reply-To: <20230314084603.de49c42bc92ad1b20d38b372@bidouilliste.com> Date: Tue, 14 Mar 2023 07:54:48 +0000 Cc: Wei Hu , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <49D67579-28BC-4734-BDF7-BC8669FFF20C@freebsd.org> References: <202303130300.32D30Q0K068420@gitrepo.freebsd.org> <4F72E2FD-6E84-40F1-981D-A18C8DE22FDD@freebsd.org> <3D6476D5-807E-4D9A-87BC-F5916FBEBE5B@freebsd.org> <20230314084603.de49c42bc92ad1b20d38b372@bidouilliste.com> To: Emmanuel Vadot X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Rspamd-Queue-Id: 4PbQmB6RlPz3CMq X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 14 Mar 2023, at 07:46, Emmanuel Vadot wrote: >=20 > On Tue, 14 Mar 2023 06:59:00 +0000 > Jessica Clarke wrote: >=20 >> On 14 Mar 2023, at 06:56, Wei Hu wrote: >>>=20 >>>>>>>> + >>>>>>>> +options COMPAT_LINUXKPI >>>>>>>> +device xz >>>>>>>> + >>>>>>>> +device mlx5 >>>>>>>> +device mlxfw >>>>>>>> +device mlx5en >>>>>>>> +options RATELIMIT >>>>=20 >>>> As pointed out on IRC, no other kernel config, aside from LINT = ones, enables >>>> this. Therefore this seems pretty dubious to add; why does >>>> arm64 need it whilst amd64, which does include Mellanox drivers in = its >>>> GENERIC, doesn't need it? >>>>=20 >>>=20 >>> How about moving these to std.nvidia? Does it look better to you? >>=20 >> They?re not part of an Nvidia SoC. >>=20 >> Anyway, I already moved them to a new std.azure. >>=20 >> Jess >>=20 >=20 > Why do we need them in GENERIC anyway ? > We have modules already built, we have devmatch, if mlx driver don't > autoload we should just fix that. I guess for the same reasons as https://reviews.freebsd.org/D28469? Jess > --=20 > Emmanuel Vadot