Re: git: c581962414ed - main - src.conf.5: Add some WITH_/WITHOUT_ option descriptions

From: Warner Losh <imp_at_bsdimp.com>
Date: Thu, 09 Mar 2023 04:12:20 UTC
On Wed, Mar 8, 2023 at 7:13 PM Ed Maste <emaste@freebsd.org> wrote:

> On Wed, 8 Mar 2023 at 18:34, John Baldwin <jhb@freebsd.org> wrote:
> >
> > On 3/8/23 3:31 PM, Ed Maste wrote:
> > > The branch main has been updated by emaste:
> > >
> > > URL:
> https://cgit.FreeBSD.org/src/commit/?id=c581962414edfc26796319ccc988647b08b03ce1
> > >
> > > commit c581962414edfc26796319ccc988647b08b03ce1
> > > Author:     Ed Maste <emaste@FreeBSD.org>
> > > AuthorDate: 2023-03-07 18:49:23 +0000
> > > Commit:     Ed Maste <emaste@FreeBSD.org>
> > > CommitDate: 2023-03-08 23:30:45 +0000
> > >
> > >      src.conf.5: Add some WITH_/WITHOUT_ option descriptions
> > >
> > >      Reviewed by:    markj, brooks
> > >      Sponsored by:   The FreeBSD Foundation
> > >      Differential Revision: https://reviews.freebsd.org/D38961
> >
> > Hah, I was just working on those, but I noticed that we don't have
> > duplicate WITH/WITHOUT options for other options so kind of punted.
>
> We already had (some) duplicates for options which have different
> defaults per architecture, like LLDB. These ones (plus
> WITH_LOADER_VERIEXEC_VECTX) were the only ones missing when running
> `make makeman`.
>
> I think there is some value to providing the list of architectures for
> WITH_ and WITHOUT_ defaults. Perhaps we could rework makeman to look
> also for a single option description (without WITH_/WITHOUT_ prefix),
> producing something like:
>
> WITH_LLDB / WITHOUT_LLDB
>         Control building of the LLDB debugger.
>
>         WITH_LLDB is the default setting on amd64/amd64, arm64/aarch64,
>         i386/i386, powerpc/powerpc and powerpc/powerpc64.
>
>         WITHOUT_LLDB is the default setting on arm/armv6, arm/armv7,
> mips/mips,
>         mips/mips64, riscv/riscv64 and riscv/riscv64sf.
>

Yea, there's no reason to have the description twice...

Warner