From nobody Thu Mar 09 04:12:20 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PXG413hszz3w5cX for ; Thu, 9 Mar 2023 04:12:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PXG406Ybrz3rnk for ; Thu, 9 Mar 2023 04:12:32 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x536.google.com with SMTP id ay14so1950225edb.11 for ; Wed, 08 Mar 2023 20:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; t=1678335151; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=D2JOftstUo43CaRfnvHaLe5ombysS7v7r7bDZiRVpAo=; b=ZgE5bsMIaAit5U4aGASTAGYytBV6vwtbyj46+ykOefn5v5UqdqEwTPklbGl8PYU6xU wLd7iRiEzPO81529qEqHwyqTGPeUep010DZTrZXSL/ACNRGhNDtSBZ79gRTYDiaO3XOh QPnKdkhDSHk4jxzFvG/kK9BnmasyIjkrz2ZdCVSg6qfxzPBLJIGtXSi9kyyAV9G+QK36 5+8EinD+UXZzWs9jXODm5011dRvW2uo2kOnYjbCfFxzpsMzWLfJg/jPqJZZb4PR7GcYv yhDACA8M9VdMfoee9Rjq4HCA4o7kZVRG7tP2znXho1sn5QV9XlwVPMgInTaa6JCzbgp2 KoHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678335151; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D2JOftstUo43CaRfnvHaLe5ombysS7v7r7bDZiRVpAo=; b=NznFWDwnbAoStGCTPiSvdeyidwIlka0Ofv/69G69i4FlfkxtmKWpEaPsJzDbLi58Gz V7LGtD3dw4sRqF974RpdsLTdPiB5G3O+AWhWbUHRtNM48GOqbhbWtldHJY3efv/z8w6W SBjLK7gtvzNxTbPMv94nGFOMQKOWeOu5zrABe8hAH/489ysKQ+yniaZbAJsN4/1125JO eNhH3L4XtaFW5LmEWgJubGhnRdw/HLW7sfKZSsQM7LcKUg18hiTyoLbXXsCq2tV5wNRX l8hy6+Kfa9RNdsSUEljao24B98joSE7f2bIi0ou4C29LmrbDPL9Mw4/cO+StldXipPy9 BxAQ== X-Gm-Message-State: AO0yUKV7std0+B8/+zgE6vTADEob1/yq2jpLz2yIJwLrccKvziwlAa7r SwrMWJdip3VFSOX8NwQVwIdF9MyKmLbyNpGnfi7Jtw== X-Google-Smtp-Source: AK7set+5zsMqolILNtkxul3y3oH+UYRmYjXOqNz0Gm/4Gpa+dHNkBNaamhM9b6M2kqvqXPT/22QjWaOsO4RztoFljJE= X-Received: by 2002:a17:906:a05a:b0:8b2:23fb:dfd1 with SMTP id bg26-20020a170906a05a00b008b223fbdfd1mr10593792ejb.2.1678335151119; Wed, 08 Mar 2023 20:12:31 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202303082331.328NViDn050541@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 8 Mar 2023 21:12:20 -0700 Message-ID: Subject: Re: git: c581962414ed - main - src.conf.5: Add some WITH_/WITHOUT_ option descriptions To: Ed Maste Cc: John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000007f321605f66fdaf1" X-Rspamd-Queue-Id: 4PXG406Ybrz3rnk X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --0000000000007f321605f66fdaf1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 8, 2023 at 7:13=E2=80=AFPM Ed Maste wrote: > On Wed, 8 Mar 2023 at 18:34, John Baldwin wrote: > > > > On 3/8/23 3:31 PM, Ed Maste wrote: > > > The branch main has been updated by emaste: > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Dc581962414edfc26796319ccc988647= b08b03ce1 > > > > > > commit c581962414edfc26796319ccc988647b08b03ce1 > > > Author: Ed Maste > > > AuthorDate: 2023-03-07 18:49:23 +0000 > > > Commit: Ed Maste > > > CommitDate: 2023-03-08 23:30:45 +0000 > > > > > > src.conf.5: Add some WITH_/WITHOUT_ option descriptions > > > > > > Reviewed by: markj, brooks > > > Sponsored by: The FreeBSD Foundation > > > Differential Revision: https://reviews.freebsd.org/D38961 > > > > Hah, I was just working on those, but I noticed that we don't have > > duplicate WITH/WITHOUT options for other options so kind of punted. > > We already had (some) duplicates for options which have different > defaults per architecture, like LLDB. These ones (plus > WITH_LOADER_VERIEXEC_VECTX) were the only ones missing when running > `make makeman`. > > I think there is some value to providing the list of architectures for > WITH_ and WITHOUT_ defaults. Perhaps we could rework makeman to look > also for a single option description (without WITH_/WITHOUT_ prefix), > producing something like: > > WITH_LLDB / WITHOUT_LLDB > Control building of the LLDB debugger. > > WITH_LLDB is the default setting on amd64/amd64, arm64/aarch64, > i386/i386, powerpc/powerpc and powerpc/powerpc64. > > WITHOUT_LLDB is the default setting on arm/armv6, arm/armv7, > mips/mips, > mips/mips64, riscv/riscv64 and riscv/riscv64sf. > Yea, there's no reason to have the description twice... Warner --0000000000007f321605f66fdaf1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Mar 8, 2023 at 7:13=E2=80=AFP= M Ed Maste <emaste@freebsd.org= > wrote:
On W= ed, 8 Mar 2023 at 18:34, John Baldwin <jhb@freebsd.org> wrote:
>
> On 3/8/23 3:31 PM, Ed Maste wrote:
> > The branch main has been updated by emaste:
> >
> > URL: htt= ps://cgit.FreeBSD.org/src/commit/?id=3Dc581962414edfc26796319ccc988647b08b0= 3ce1
> >
> > commit c581962414edfc26796319ccc988647b08b03ce1
> > Author:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org> > > AuthorDate: 2023-03-07 18:49:23 +0000
> > Commit:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org> > > CommitDate: 2023-03-08 23:30:45 +0000
> >
> >=C2=A0 =C2=A0 =C2=A0 src.conf.5: Add some WITH_/WITHOUT_ option de= scriptions
> >
> >=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 markj, brooks
> >=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0The FreeBSD Foundat= ion
> >=C2=A0 =C2=A0 =C2=A0 Differential Revision: https://revie= ws.freebsd.org/D38961
>
> Hah, I was just working on those, but I noticed that we don't have=
> duplicate WITH/WITHOUT options for other options so kind of punted.
We already had (some) duplicates for options which have different
defaults per architecture, like LLDB. These ones (plus
WITH_LOADER_VERIEXEC_VECTX) were the only ones missing when running
`make makeman`.

I think there is some value to providing the list of architectures for
WITH_ and WITHOUT_ defaults. Perhaps we could rework makeman to look
also for a single option description (without WITH_/WITHOUT_ prefix),
producing something like:

WITH_LLDB / WITHOUT_LLDB
=C2=A0 =C2=A0 =C2=A0 =C2=A0 Control building of the LLDB debugger.

=C2=A0 =C2=A0 =C2=A0 =C2=A0 WITH_LLDB is the default setting on amd64/amd64= , arm64/aarch64,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 i386/i386, powerpc/powerpc and powerpc/powerpc6= 4.

=C2=A0 =C2=A0 =C2=A0 =C2=A0 WITHOUT_LLDB is the default setting on arm/armv= 6, arm/armv7, mips/mips,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 mips/mips64, riscv/riscv64 and riscv/riscv64sf.=

Yea, there's no reason to have the= description twice...

Warner=C2=A0
--0000000000007f321605f66fdaf1--