Re: git: 6ad2a9a64f34 - main - ix: remove stale comment

Am Tue, 11 Jul 2023 16:45:05 GMT
Piotr Kubaj <pkubaj@FreeBSD.org> schrieb:

> The branch main has been updated by pkubaj:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=6ad2a9a64f34ea3b376c3064fcba30b3c8e654dd
> 
> commit 6ad2a9a64f34ea3b376c3064fcba30b3c8e654dd
> Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
> AuthorDate: 2023-07-11 16:45:04 +0000
> Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
> CommitDate: 2023-07-11 16:45:04 +0000
> 
>     ix: remove stale comment
>     
>     Reported by:    Navdeep Parhar
> ---
>  sys/dev/ixgbe/if_ix.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c
> index 09c0a82279ed..45ab7c27233a 100644
> --- a/sys/dev/ixgbe/if_ix.c
> +++ b/sys/dev/ixgbe/if_ix.c
> @@ -3678,7 +3678,6 @@ ixgbe_if_update_admin_status(if_ctx_t ctx)
>  			ixgbe_fc_enable(&sc->hw);
>  			/* Update DMA coalescing config */
>  			ixgbe_config_dmac(sc);
> -			/* should actually be negotiated value */
>  			iflib_link_state_change(ctx, LINK_STATE_UP,
>  			    ixgbe_link_speed_to_baudrate(adapter->link_speed));
>  
> 

Buildkernel seems to fail due to:

[...]
/usr/src/sys/dev/ixgbe/if_ixv.c:940:37: error: use of undeclared identifier 'adapter'
                            ixgbe_link_speed_to_baudrate(adapter->link_speed));



-- 
O. Hartmann