From nobody Tue Jul 11 17:03:22 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R0nJs3ty6z4lRXR; Tue, 11 Jul 2023 17:03:57 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from smtp052.goneo.de (smtp5.goneo.de [IPv6:2001:1640:5::8:30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4R0nJs1tqbz3t0X; Tue, 11 Jul 2023 17:03:57 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Authentication-Results: mx1.freebsd.org; none Received: from hub2.goneo.de (hub2.goneo.de [85.220.129.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp5.goneo.de (Postfix) with ESMTPS id 83BA110A1E8F; Tue, 11 Jul 2023 19:03:52 +0200 (CEST) Received: from hub2.goneo.de (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPS id A7153105C659; Tue, 11 Jul 2023 19:03:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walstatt-de.de; s=DKIM001; t=1689095030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=taqvkZn73JoMv/vl5533jedPV4OK86gDjZxNdkEnub4=; b=QjHCo8HbY2fCt/nrEF61pOS5SyRqS8/BmTyMw7HQeq5vHrmoMOIizH+mB9kfZpkx5odmo7 miN25AfHmxvbEvu/K73YQ3n4dYzPuI9cw2oX0M5StjEcHceFD6upD8yp9vLpXrfi2GNh51 VyGE8mNgTVyLB6cpmE+tN4eYDDXPG4MAqrBj7K8ulgGs62tpPNQq+dZOeFHe4DRO2YA8tm A0sM6BiXds3kAJowQqEHGHEwekvxrz7qJBlWuN5UcAy0/AZgZuxniaV/WrZ3HheTHyRwOR 6xRCztGpgkM7lbIrV+QWqbgDBme/sIa+F3/Nat9dGvHtlkaORtlEV0Uajv16hg== Received: from thor.intern.walstatt.dynvpn.de (dynamic-077-191-145-176.77.191.pool.telefonica.de [77.191.145.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPSA id 5F1DD105C5C4; Tue, 11 Jul 2023 19:03:50 +0200 (CEST) Date: Tue, 11 Jul 2023 19:03:22 +0200 From: FreeBSD User To: Piotr Kubaj Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 6ad2a9a64f34 - main - ix: remove stale comment Message-ID: <20230711190349.632481df@thor.intern.walstatt.dynvpn.de> In-Reply-To: <202307111645.36BGj5K9072743@gitrepo.freebsd.org> References: <202307111645.36BGj5K9072743@gitrepo.freebsd.org> Organization: walstatt-de.de List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-UID: be60e6 X-Rspamd-UID: 8e4965 X-Rspamd-Queue-Id: 4R0nJs1tqbz3t0X X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:25394, ipnet:2001:1640::/32, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Am Tue, 11 Jul 2023 16:45:05 GMT Piotr Kubaj schrieb: > The branch main has been updated by pkubaj: > > URL: https://cgit.FreeBSD.org/src/commit/?id=6ad2a9a64f34ea3b376c3064fcba30b3c8e654dd > > commit 6ad2a9a64f34ea3b376c3064fcba30b3c8e654dd > Author: Piotr Kubaj > AuthorDate: 2023-07-11 16:45:04 +0000 > Commit: Piotr Kubaj > CommitDate: 2023-07-11 16:45:04 +0000 > > ix: remove stale comment > > Reported by: Navdeep Parhar > --- > sys/dev/ixgbe/if_ix.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c > index 09c0a82279ed..45ab7c27233a 100644 > --- a/sys/dev/ixgbe/if_ix.c > +++ b/sys/dev/ixgbe/if_ix.c > @@ -3678,7 +3678,6 @@ ixgbe_if_update_admin_status(if_ctx_t ctx) > ixgbe_fc_enable(&sc->hw); > /* Update DMA coalescing config */ > ixgbe_config_dmac(sc); > - /* should actually be negotiated value */ > iflib_link_state_change(ctx, LINK_STATE_UP, > ixgbe_link_speed_to_baudrate(adapter->link_speed)); > > Buildkernel seems to fail due to: [...] /usr/src/sys/dev/ixgbe/if_ixv.c:940:37: error: use of undeclared identifier 'adapter' ixgbe_link_speed_to_baudrate(adapter->link_speed)); -- O. Hartmann