Re: git: c81495a621c4 - main - fwget: Fix quoting

 Hi Mateusz,

On Fri, 7 Jul 2023 18:48:23 +0200
Mateusz Piotrowski <0mp@FreeBSD.org> wrote:

> Hey Manu,
> 
> 
> > On 7. Jul 2023, at 09:19, Emmanuel Vadot <manu@FreeBSD.org> wrote:
> > 
> > The branch main has been updated by manu:
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=c81495a621c461b3d3395a7c5b0e73458201c443
> > 
> > commit c81495a621c461b3d3395a7c5b0e73458201c443
> > Author:     Emmanuel Vadot <manu@FreeBSD.org>
> > AuthorDate: 2023-07-07 07:16:05 +0000
> > Commit:     Emmanuel Vadot <manu@FreeBSD.org>
> > CommitDate: 2023-07-07 07:19:41 +0000
> > 
> >    fwget: Fix quoting
> > 
> >    This kind of quoting doesn't work, no idea why shellcheck wanted this.
> >    If there is a "safer" way to "fix" this feel free to do it just test
> >    that it's working after.
> > 
> >    Reported by:    Kenneth Raplee <kenrap@kennethraplee.com>
> >    Sponsored by:   Beckhoff Automation GmbH & Co. KG
> >    Fixes:  7ad4d94d5bf2 ("Fix some shell issues by adding quotes and replace backticks with $()")
> > ---
> > usr.sbin/fwget/fwget.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/usr.sbin/fwget/fwget.sh b/usr.sbin/fwget/fwget.sh
> > index 61acaee86687..90bc23b07077 100644
> > --- a/usr.sbin/fwget/fwget.sh
> > +++ b/usr.sbin/fwget/fwget.sh
> > @@ -27,7 +27,7 @@
> > # IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> > # POSSIBILITY OF SUCH DAMAGE.
> > 
> > -: "${LIBEXEC_PATH:='/usr/libexec/fwget'}"
> > +: ${LIBEXEC_PATH:="/usr/libexec/fwget"}
> 
> What was the reported bug here? Quoting here looks alright.

 See bcr@ commit, I think it was "- Quote default assignments (SC2223)"

 Cheers,

> 
> > 
> > usage()
> > {
> > 
> 
> 
> 
> Best,
> 
> Mateusz
> 


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>