From nobody Sat Jul 08 07:32:01 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qyhmg1f5bz4mDGy; Sat, 8 Jul 2023 07:32:19 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qyhmd0WpDz3vhW; Sat, 8 Jul 2023 07:32:16 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1688801525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wEchf4t+UD/zvSzu1MJ+Bxu7nRM46mTu0KPtm+YUyb0=; b=iBof6lJSL1jO5kARBnVJpbU2X1kfiR6hrIRN0Ysjt1k09Hhg2XxLJQKpLj2tYA/BcvWL+h BPYlezeyUZsQetpOJp9k7ZWBnrjim9XBsKPBZssJpzMKdhXGb5fPn19GzaL0akby2UbGlk DQunx7ZGYaMDoNpuvavFVQ67yPeYz/w= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 73b85500 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 8 Jul 2023 07:32:04 +0000 (UTC) Date: Sat, 8 Jul 2023 09:32:01 +0200 From: Emmanuel Vadot To: Mateusz Piotrowski <0mp@FreeBSD.org> Cc: Emmanuel Vadot , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: c81495a621c4 - main - fwget: Fix quoting Message-Id: <20230708093201.60f020f9e809aebf35f2fab5@bidouilliste.com> In-Reply-To: <98DC3116-140D-47C8-8B33-E5C666A76D75@FreeBSD.org> References: <202307070719.3677JqSM058134@gitrepo.freebsd.org> <98DC3116-140D-47C8-8B33-E5C666A76D75@FreeBSD.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Qyhmd0WpDz3vhW X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Hi Mateusz, On Fri, 7 Jul 2023 18:48:23 +0200 Mateusz Piotrowski <0mp@FreeBSD.org> wrote: > Hey Manu, > > > > On 7. Jul 2023, at 09:19, Emmanuel Vadot wrote: > > > > The branch main has been updated by manu: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=c81495a621c461b3d3395a7c5b0e73458201c443 > > > > commit c81495a621c461b3d3395a7c5b0e73458201c443 > > Author: Emmanuel Vadot > > AuthorDate: 2023-07-07 07:16:05 +0000 > > Commit: Emmanuel Vadot > > CommitDate: 2023-07-07 07:19:41 +0000 > > > > fwget: Fix quoting > > > > This kind of quoting doesn't work, no idea why shellcheck wanted this. > > If there is a "safer" way to "fix" this feel free to do it just test > > that it's working after. > > > > Reported by: Kenneth Raplee > > Sponsored by: Beckhoff Automation GmbH & Co. KG > > Fixes: 7ad4d94d5bf2 ("Fix some shell issues by adding quotes and replace backticks with $()") > > --- > > usr.sbin/fwget/fwget.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/usr.sbin/fwget/fwget.sh b/usr.sbin/fwget/fwget.sh > > index 61acaee86687..90bc23b07077 100644 > > --- a/usr.sbin/fwget/fwget.sh > > +++ b/usr.sbin/fwget/fwget.sh > > @@ -27,7 +27,7 @@ > > # IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > > # POSSIBILITY OF SUCH DAMAGE. > > > > -: "${LIBEXEC_PATH:='/usr/libexec/fwget'}" > > +: ${LIBEXEC_PATH:="/usr/libexec/fwget"} > > What was the reported bug here? Quoting here looks alright. See bcr@ commit, I think it was "- Quote default assignments (SC2223)" Cheers, > > > > > usage() > > { > > > > > > Best, > > Mateusz > -- Emmanuel Vadot