Re: git: 55e0aefae688 - main - ping: low-effort fix to make it compilable without inet6
Date: Wed, 05 Jul 2023 12:31:33 UTC
On 7/5/23, Jessica Clarke <jrtc27@freebsd.org> wrote: > On 5 Jul 2023, at 11:03, Mateusz Guzik <mjg@FreeBSD.org> wrote: >> >> The branch main has been updated by mjg: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=55e0aefae688075718e212594e823fe5fbfba4bf >> >> commit 55e0aefae688075718e212594e823fe5fbfba4bf >> Author: Mateusz Guzik <mjg@FreeBSD.org> >> AuthorDate: 2023-07-05 09:59:40 +0000 >> Commit: Mateusz Guzik <mjg@FreeBSD.org> >> CommitDate: 2023-07-05 10:02:32 +0000 >> >> ping: low-effort fix to make it compilable without inet6 >> --- >> sbin/ping/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/sbin/ping/Makefile b/sbin/ping/Makefile >> index 23bac6d62d90..ad5dce03363f 100644 >> --- a/sbin/ping/Makefile >> +++ b/sbin/ping/Makefile >> @@ -34,6 +34,8 @@ CFLAGS+=-DWITH_CASPER >> CFLAGS+=-DIPSEC >> LIBADD+= ipsec >> >> +CFLAGS+= -Wno-error=unused-but-set-variable >> + > > If we’re going to go with bodges like this should they not at least be > gated on MK_INET6 == no or similar? Otherwise the default build where > we are warning-clean today isn’t going to fail when new warnings are > introduced, which is sub-optimal. > That is a valid point but I don't think it warrants patching anything -- note that detection of the issue remains enabled, it just no longer fails the build. Thus if someone was to patch ping and build it standalone, they will still see the message. That said, if someone insists on tightening when the flag is used, I'm not going to stand in the way. -- Mateusz Guzik <mjguzik gmail.com>