From nobody Wed Jul 05 12:31:33 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QwzYN2PH7z4lqpL; Wed, 5 Jul 2023 12:31:36 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-oo1-xc31.google.com (mail-oo1-xc31.google.com [IPv6:2607:f8b0:4864:20::c31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QwzYN033vz4DR3; Wed, 5 Jul 2023 12:31:36 +0000 (UTC) (envelope-from mjguzik@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-oo1-xc31.google.com with SMTP id 006d021491bc7-5634808e16eso4618641eaf.2; Wed, 05 Jul 2023 05:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688560294; x=1691152294; h=content-transfer-encoding:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uB22mReXrzxWg1ET03Yj8WSrfwDhZTAHfIhNK0SK9bU=; b=e0n9FWcx9/l/Ta5z+WipE3UWeGszyL6rto1ioHosyqqA24m9W1uwg1R7B+T4LZGZod ieVOtGVDi3nRybJTCKJGYgVA7eQHBbNqcr6yW+AxTYrwWufvfwYZRYnSAvQepjDSvV/p Qn3Lwydsg5LXRTWSObzj1pjhbE7Yn5SF6kr0xe12DLKk/Ys4eAeDrbI5te5U6qdUA90C X7wEBtXG1l5wkwrwt1Pfb00BlJz9hu7iTBFHcSoDKQOnh1oUhe1MDQ16qtvrqrqfxRDN 7ibDy1zHxcNLBWZ+5T74OqT0/GOXYUsHKMP3mjInPsq/PR8K64EWSbGThD4DkdH+DWqM l1DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688560294; x=1691152294; h=content-transfer-encoding:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uB22mReXrzxWg1ET03Yj8WSrfwDhZTAHfIhNK0SK9bU=; b=NhkT/1kJGOnlTQPH4MWDMY8dRaDgkIoURFQ9N2jOKztjipQk79H830x9nCLSTrbsbq t+rBoZcbi2GxbUst3TF8FG08m90xb0sBhAp5kFRiO6vL8gfYkTGRGNej5H9MIkS54PY7 PvOAP6Zeai3fB0LV3yr2cgtxaRJOQzBWcGxennr3BmBcpjWBbEC/Ybv0BFgsqsyO4pGC zuPfKMGMbG0EZPadNrVjYMq7yed3gT5PG/0Z+xq1XL+mubVHfimg7ophc3xztspJFyA1 LItklogPd9ryNfb8qnc6jgoNGSWCryfOAKCo4rJm5jqZG9DYnhQKUK18eLckRYShd752 ROdQ== X-Gm-Message-State: AC+VfDwuqvXOFhfTT0IThwGK1qMPqb+p2KzcHO8b1QcPjoikR4xl2GEq D8eXGd3h3xk/9x2PbUTtojHWSUWVMmB+N3HDVmrYKWAC X-Google-Smtp-Source: ACHHUZ6+Dw5e0/Ile8tjaZ5cDBCYpaD+kzZ2gLgBJbqpjrYRKUP6gyelR4PZ7TDzOWr5FWYxy6clG/sjf2CEMyWOkio= X-Received: by 2002:a4a:d64e:0:b0:565:a8a8:6601 with SMTP id y14-20020a4ad64e000000b00565a8a86601mr12151471oos.8.1688560294079; Wed, 05 Jul 2023 05:31:34 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Received: by 2002:a8a:1109:0:b0:4e1:6042:cdc9 with HTTP; Wed, 5 Jul 2023 05:31:33 -0700 (PDT) In-Reply-To: References: <202307051003.365A3RqR072876@gitrepo.freebsd.org> From: Mateusz Guzik Date: Wed, 5 Jul 2023 14:31:33 +0200 Message-ID: Subject: Re: git: 55e0aefae688 - main - ping: low-effort fix to make it compilable without inet6 To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4QwzYN033vz4DR3 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 7/5/23, Jessica Clarke wrote: > On 5 Jul 2023, at 11:03, Mateusz Guzik wrote: >> >> The branch main has been updated by mjg: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=3D55e0aefae688075718e212594e823f= e5fbfba4bf >> >> commit 55e0aefae688075718e212594e823fe5fbfba4bf >> Author: Mateusz Guzik >> AuthorDate: 2023-07-05 09:59:40 +0000 >> Commit: Mateusz Guzik >> CommitDate: 2023-07-05 10:02:32 +0000 >> >> ping: low-effort fix to make it compilable without inet6 >> --- >> sbin/ping/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/sbin/ping/Makefile b/sbin/ping/Makefile >> index 23bac6d62d90..ad5dce03363f 100644 >> --- a/sbin/ping/Makefile >> +++ b/sbin/ping/Makefile >> @@ -34,6 +34,8 @@ CFLAGS+=3D-DWITH_CASPER >> CFLAGS+=3D-DIPSEC >> LIBADD+=3D ipsec >> >> +CFLAGS+=3D -Wno-error=3Dunused-but-set-variable >> + > > If we=E2=80=99re going to go with bodges like this should they not at lea= st be > gated on MK_INET6 =3D=3D no or similar? Otherwise the default build where > we are warning-clean today isn=E2=80=99t going to fail when new warnings = are > introduced, which is sub-optimal. > That is a valid point but I don't think it warrants patching anything -- note that detection of the issue remains enabled, it just no longer fails the build. Thus if someone was to patch ping and build it standalone, they will still see the message. That said, if someone insists on tightening when the flag is used, I'm not going to stand in the way. --=20 Mateusz Guzik