Re: git: 78cfa762ebf2 - main - callout: Move per-CPU callout state into the dpcpu region

In reply to: Hans Petter Selasky : "Re: git: 78cfa762ebf2 - main - callout: Move per-CPU callout state into the dpcpu region"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Mark Johnston <markj_at_freebsd.org>
Date: Wed, 26 Apr 2023 14:45:44 UTC

On Wed, Apr 26, 2023 at 04:42:06PM +0200, Hans Petter Selasky wrote:
> On 4/26/23 16:13, Mark Johnston wrote:
> > -	mtx_init(&cc->cc_lock, "callout", NULL, MTX_SPIN);
> > +	mtx_init(&cc->cc_lock, "callout", NULL, MTX_SPIN | MTX_NEW);
> 
> Is the MTX_NEW needed? Shouldn't the DCPU memory be zeroed by default?

I think you are right, it shouldn't be needed.  I'll retest without it.