From nobody Wed Apr 26 14:45:44 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q61rY3dM6z46c7Z; Wed, 26 Apr 2023 14:45:49 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q61rY03WXz3Fp3; Wed, 26 Apr 2023 14:45:49 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-74e19dcf217so360872985a.2; Wed, 26 Apr 2023 07:45:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682520348; x=1685112348; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=DTNOPyVGDzGLoRSnxes4GpXBzaEl9kNpFQk/7ttlrwk=; b=TLiv72mVd8FzUNl+cJMU3+PViYKqntYzAQSnoTUvMzZCKJK6MaL8hb2QxTGjPpTQGP nnuVmy8q7QTJDsgTpUSVC2Dl1L0NbXa655J5d7vjiCWoiWGs4HpNyz/czpJLO5vBQB5C eyjSq04lpjHF53qhXoWa/f0X5BJRw9iBGzT5oGvaM8Gabk6lsmzRIURYTZPxxjk2a3SA a3b2apjAXcttSsUhVA5vwecBwlr0maJLn6sa1asPJtXv3F0T4K2JPqsqR9Rco4daWHT4 AY0hn4EMctJtDm45Ui5OL8Vym/f4wjNiwATIe7YwmhG4A+1vXx4j1EO3t4O8xPiEgIKD BS7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682520348; x=1685112348; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DTNOPyVGDzGLoRSnxes4GpXBzaEl9kNpFQk/7ttlrwk=; b=EJ6RwieGp8VExoVhWEzD2OlyVYRRajFqRB7KzrsrFZEH+L4dKTpaDNLxX5qFWNo8B4 QT3B70G8WnKr+WiBnWHA6JuQUEQiu1yzBoJyMKcw9EycFUdoBXbMwOi0MQxtjSoQ1n50 sQ/rhZsAUN68LKVEmmQ9CwkJ8uKxZ52FBB3EgACCjD63y89f3inQ9CWAfngKpFk57ZyJ FgSg3ld6x3b86CzGChRNLLrGoZqwxCPYLz67NV/dNkfopXfgAqpijtV+2pncX/odcmZ7 yPnlnTCYaDu9R0F7f3SQG1OE9bJd8lRYSNPVPE8jnWAGzo01t69NUgdun/maS4RaKxGI b3Lw== X-Gm-Message-State: AAQBX9fLF6255gp3+pD5Fr7y4fCSgVVY/lcmrHa2eM8skG3OA/Gw6Vb7 AAntPc6g2dr5g582vK1W8VZchV70llQ= X-Google-Smtp-Source: AKy350azWyEJ1WD2q55sxnU4Pi42GfTRFJqHZYhTX4qo/PfPfhRL9w5vH08xgaaxgHpdPz6akD7jwA== X-Received: by 2002:a05:6214:20e2:b0:5f1:6892:7437 with SMTP id 2-20020a05621420e200b005f168927437mr32537376qvk.26.1682520348103; Wed, 26 Apr 2023 07:45:48 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id a24-20020a0ca998000000b005dd8b9345basm4909697qvb.82.2023.04.26.07.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 07:45:47 -0700 (PDT) Date: Wed, 26 Apr 2023 10:45:44 -0400 From: Mark Johnston To: Hans Petter Selasky Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 78cfa762ebf2 - main - callout: Move per-CPU callout state into the dpcpu region Message-ID: References: <202304261413.33QEDxBD086666@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4Q61rY03WXz3Fp3 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Wed, Apr 26, 2023 at 04:42:06PM +0200, Hans Petter Selasky wrote: > On 4/26/23 16:13, Mark Johnston wrote: > > - mtx_init(&cc->cc_lock, "callout", NULL, MTX_SPIN); > > + mtx_init(&cc->cc_lock, "callout", NULL, MTX_SPIN | MTX_NEW); > > Is the MTX_NEW needed? Shouldn't the DCPU memory be zeroed by default? I think you are right, it shouldn't be needed. I'll retest without it.