Re: 8ee579abe09e - main - zfs: fall back if block_cloning feature is disabled

From: Cy Schubert <Cy.Schubert_at_cschubert.com>
Date: Tue, 04 Apr 2023 19:48:46 UTC
On Tue, 4 Apr 2023 12:30:54 -0700
Cy Schubert <Cy.Schubert@cschubert.com> wrote:

> On Tue, 4 Apr 2023 17:54:28 +0000
> "Pokala, Ravi" <rpokala@panasas.com> wrote:
> 
> > Cy,
> > 
> > The patch adds 'bool done_outvp', unconditionally sets it to 'true', and then later has a check for 'if (!done_outvp)'. Since there is no intervening place where 'done_outvp' could be set to 'false', that check will never succeed and that branch is unreachable.  
> 
> It's set to false at line 6454, in the loop locking vnodes.
> 
> > 
> > Or am I mis-reading something?  
> 
> Maybe Rick can explain but all we're doing is ensuring that the first
> part of the loop is executed only first time through. We could invert it
> and save setting it to false every loop.

No. Looking at it more closely, I was wrong. What Rick is doing is
probably the best approach.

> 
> > 
> > Thanks,
> > 
> > Ravi (rpokala@)
> >   
> 

I'll try to put together a review tonight. Having said that, I don't
want to take the credit for this "final" fix. We have Martin and Rick
to thank for doing the heavy lifting.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e^(i*pi)+1=0