From nobody Tue Apr 04 19:48:46 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PrdcM2V9sz445C3; Tue, 4 Apr 2023 19:48:51 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PrdcL56hyz4KQj; Tue, 4 Apr 2023 19:48:50 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 3.97.99.32) smtp.mailfrom=cy.schubert@cschubert.com; dmarc=none Received: from shw-obgw-4001a.ext.cloudfilter.net ([10.228.9.142]) by cmsmtp with ESMTP id jhbppqP9PuZMSjmeApyFMD; Tue, 04 Apr 2023 19:48:50 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id jme6pO8nGHFsOjme8pB5no; Tue, 04 Apr 2023 19:48:50 +0000 X-Authority-Analysis: v=2.4 cv=XZqaca15 c=1 sm=1 tr=0 ts=642c7f22 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=dKHAf1wccvYA:10 a=YxBL1-UpAAAA:8 a=cOLrLDMxAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=34e_Na1dGkdcksqxHTkA:9 a=CjuIK1q_8ugA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=P0s3qUPvOpV5zndjNR8V:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 428D33B4; Tue, 4 Apr 2023 12:48:46 -0700 (PDT) Received: from slippy (localhost [IPv6:::1]) by slippy.cwsent.com (Postfix) with ESMTP id 1CE5B133; Tue, 4 Apr 2023 12:48:46 -0700 (PDT) Date: Tue, 4 Apr 2023 12:48:46 -0700 From: Cy Schubert To: "Pokala, Ravi" Cc: Martin Matuska , Rick Macklem , Mateusz Guzik , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: 8ee579abe09e - main - zfs: fall back if block_cloning feature is disabled Message-ID: <20230404124846.576d26fd@slippy> In-Reply-To: <20230404123054.6cf5fb6b@slippy> References: <202304041145.334Bjx6l035872@gitrepo.freebsd.org> <20230404141717.B976D31C@slippy.cwsent.com> <98c71e6f-5b48-79f3-e7b0-95d674949624@FreeBSD.org> <20230404091844.639cb1c1@slippy> <5B7F71CC-5BE6-4938-A29E-E10B01A4E4ED@panasas.com> <20230404123054.6cf5fb6b@slippy> Organization: KOMQUATS X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfFGDq6Rztuwaosb0IrAqoP7EqsvxVl1pDqIEGE7dVR4+6TiA4e3Ci9aFlKzBPBeliQlMm3xvs0F9DVaIq9uInu/loBORp84dqRka/3Bna6UnEOev4C4r Pf/HP23ddwjxYMSnQE0EKAEBsOxZAOjq7Z3PAXj11SABds0PFYi5aeQxrne+ZO3lkEoh0d2N5iwFNFceO8x4JBkiWw1ST0Bt4Wq6fQ9GOMBQIViIlxid02p6 jQK1GyPuyM99vjBBBr+kmHrKs3kRH145BmiiQyQdOpZotnDJ7XHCTGMrDZL82FBEqJSqyWL/emUs6aSeNgAWFoooABq28C9M8YEzKhymuT95AOEn8LTVHTJq iomMTiG0lI0dYBAgQ4Y697PQpHcLTxTaG9tOvfF+9pavAH1xiJVLfWl23qc2Ue2Qe2480fTd X-Spamd-Result: default: False [-0.30 / 15.00]; SUSPICIOUS_RECIPS(1.50)[]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.997]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_IN_DNSWL_MED(-0.20)[3.97.99.32:from]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; TAGGED_RCPT(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[3.97.99.32:from]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; HAS_ORG_HEADER(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; FREEMAIL_CC(0.00)[FreeBSD.org,gmail.com,freebsd.org]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[] X-Rspamd-Queue-Id: 4PrdcL56hyz4KQj X-Spamd-Bar: / X-ThisMailContainsUnwantedMimeParts: N On Tue, 4 Apr 2023 12:30:54 -0700 Cy Schubert wrote: > On Tue, 4 Apr 2023 17:54:28 +0000 > "Pokala, Ravi" wrote: > > > Cy, > > > > The patch adds 'bool done_outvp', unconditionally sets it to 'true', and then later has a check for 'if (!done_outvp)'. Since there is no intervening place where 'done_outvp' could be set to 'false', that check will never succeed and that branch is unreachable. > > It's set to false at line 6454, in the loop locking vnodes. > > > > > Or am I mis-reading something? > > Maybe Rick can explain but all we're doing is ensuring that the first > part of the loop is executed only first time through. We could invert it > and save setting it to false every loop. No. Looking at it more closely, I was wrong. What Rick is doing is probably the best approach. > > > > > Thanks, > > > > Ravi (rpokala@) > > > I'll try to put together a review tonight. Having said that, I don't want to take the credit for this "final" fix. We have Martin and Rick to thank for doing the heavy lifting. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0