Re: git: 8c82b37461fa - main - ipfilter: Adjust kernel module returns to conform to style(9)

From: Jessica Clarke <jrtc27_at_freebsd.org>
Date: Tue, 04 Jan 2022 02:29:48 UTC
On 4 Jan 2022, at 02:07, Cy Schubert <cy@FreeBSD.org> wrote:
> 
> The branch main has been updated by cy:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=8c82b37461fa4e60276639df214100fbf559ea6e
> 
> commit 8c82b37461fa4e60276639df214100fbf559ea6e
> Author:     Cy Schubert <cy@FreeBSD.org>
> AuthorDate: 2021-12-22 02:35:12 +0000
> Commit:     Cy Schubert <cy@FreeBSD.org>
> CommitDate: 2022-01-04 02:06:43 +0000
> 
>    ipfilter: Adjust kernel module returns to conform to style(9)
> 
>    Adjust ipfilter's kernel module return statements to conform to style(9).
> 
>    MFC after:      1 month
> ---
> sys/netpfil/ipfilter/netinet/fil.c            | 680 +++++++++++++-------------
> sys/netpfil/ipfilter/netinet/ip_auth.c        |  70 +--
> sys/netpfil/ipfilter/netinet/ip_dns_pxy.c     |  44 +-
> sys/netpfil/ipfilter/netinet/ip_dstlist.c     |  92 ++--
> sys/netpfil/ipfilter/netinet/ip_fil_freebsd.c | 148 +++---
> sys/netpfil/ipfilter/netinet/ip_frag.c        |  88 ++--
> sys/netpfil/ipfilter/netinet/ip_ftp_pxy.c     | 190 +++----
> sys/netpfil/ipfilter/netinet/ip_htable.c      | 120 ++---
> sys/netpfil/ipfilter/netinet/ip_ipsec_pxy.c   |  40 +-
> sys/netpfil/ipfilter/netinet/ip_irc_pxy.c     |  64 +--
> sys/netpfil/ipfilter/netinet/ip_log.c         |  64 +--
> sys/netpfil/ipfilter/netinet/ip_lookup.c      |  66 +--
> sys/netpfil/ipfilter/netinet/ip_nat.c         | 392 +++++++--------
> sys/netpfil/ipfilter/netinet/ip_nat6.c        | 196 ++++----
> sys/netpfil/ipfilter/netinet/ip_netbios_pxy.c |   4 +-
> sys/netpfil/ipfilter/netinet/ip_pool.c        | 120 ++---
> sys/netpfil/ipfilter/netinet/ip_pptp_pxy.c    |  28 +-
> sys/netpfil/ipfilter/netinet/ip_proxy.c       |  96 ++--
> sys/netpfil/ipfilter/netinet/ip_raudio_pxy.c  |  28 +-
> sys/netpfil/ipfilter/netinet/ip_rcmd_pxy.c    |  30 +-
> sys/netpfil/ipfilter/netinet/ip_rpcb_pxy.c    |   4 +-
> sys/netpfil/ipfilter/netinet/ip_rules.c       |  28 +-
> sys/netpfil/ipfilter/netinet/ip_scan.c        |  58 +--
> sys/netpfil/ipfilter/netinet/ip_state.c       | 260 +++++-----
> sys/netpfil/ipfilter/netinet/ip_sync.c        |  64 +--
> sys/netpfil/ipfilter/netinet/ip_tftp_pxy.c    |  36 +-
> sys/netpfil/ipfilter/netinet/ipf_rb.h         |   6 +-
> sys/netpfil/ipfilter/netinet/mlfk_ipl.c       |  50 +-
> sys/netpfil/ipfilter/netinet/radix_ipf.c      |  64 +--
> 29 files changed, 1565 insertions(+), 1565 deletions(-)
> 
> diff --git a/sys/netpfil/ipfilter/netinet/fil.c b/sys/netpfil/ipfilter/netinet/fil.c
> index 282f056e17e8..f5c15b8724d1 100644
> --- a/sys/netpfil/ipfilter/netinet/fil.c
> +++ b/sys/netpfil/ipfilter/netinet/fil.c
> @@ -624,12 +624,12 @@ ipf_pr_ipv6exthdr(fr_info_t *fin, int multiple, int proto)
> 	if ((fin->fin_dlen - 8) < 0) {
> 		fin->fin_flx |= FI_SHORT;
> 		LBUMPD(ipf_stats[fin->fin_out], fr_v6_ext_short);
> -		return NULL;
> +		return(NULL);

style(9) includes a space after return.

> [...]
> @@ -832,11 +832,11 @@ ipf_pr_fragment6(fr_info_t *fin)
> 	/*
> 	 * We don't know where the transport layer header (or whatever is next
> 	 * is), as it could be behind destination options (amongst others) so
> -	 * return the fragment header as the type of packet this is.  Note that
> +	* return the fragment header as the type of packet this is.  Note that

Somehow you’ve lost the space for a few of these.

Jess