From nobody Tue Jan 04 02:29:48 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9160219285FF for ; Tue, 4 Jan 2022 02:29:58 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JSc5f3Vzvz3LwJ for ; Tue, 4 Jan 2022 02:29:58 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f49.google.com with SMTP id b186-20020a1c1bc3000000b00345734afe78so714763wmb.0 for ; Mon, 03 Jan 2022 18:29:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7sfl0jncfkBOB6BhbPoLw8l4IiCnz3QxR5xz21hOn/0=; b=UptnXk/M80q1o3wSyf642TWyl3jpd9YiZNCBbBsj2BIoSdXkAxktuxjUyLzFKD3C7Q FIemKbbwIm4kVmE/fsfKOBqzVSopQycf1HPyQRNkGCXZDyiaJwdGVAuspYIU838Oj0Z9 Ndt3q4IOjMzh9MkHLLMgTUbBq3igHgtpqQfh82ZRoM1FgSe4cUi8R+k/6qUhBbUqno3e +02rUNe34gxYQrCEJgentSvGc+/NL9rR9eyGZp744UKuhFfGNl8Q3/PmnX+GAb1256bS NHUztSn7dhc1zc+n/tvcLl8odSAYETyfmpclvfJRJmzl9s+PQoi5Ydthb8ZuVRbDgmAs pjqA== X-Gm-Message-State: AOAM532kfInpAQrnYNTRA8PoGVq4kvv8eDcCAvij0db3ROKP5yN368tW gvJimcEOBEry9Ga25ATDaMfexw== X-Google-Smtp-Source: ABdhPJz3OIv1yVHDTzdGrQxbbX+RmopqzCMfT8K1Cun9iW8Fzu1W969YPzF7PWpcPPYJPEdjx1C6JA== X-Received: by 2002:a7b:c397:: with SMTP id s23mr39799447wmj.183.1641263391414; Mon, 03 Jan 2022 18:29:51 -0800 (PST) Received: from smtpclient.apple (global-5-141.nat-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id d22sm36000906wmq.17.2022.01.03.18.29.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jan 2022 18:29:51 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: git: 8c82b37461fa - main - ipfilter: Adjust kernel module returns to conform to style(9) From: Jessica Clarke In-Reply-To: <202201040207.20427ce3042660@gitrepo.freebsd.org> Date: Tue, 4 Jan 2022 02:29:48 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <0FEA9FF9-7DB6-48B5-81BB-DA3064235D40@freebsd.org> References: <202201040207.20427ce3042660@gitrepo.freebsd.org> To: Cy Schubert X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4JSc5f3Vzvz3LwJ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 4 Jan 2022, at 02:07, Cy Schubert wrote: >=20 > The branch main has been updated by cy: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D8c82b37461fa4e60276639df214100fb= f559ea6e >=20 > commit 8c82b37461fa4e60276639df214100fbf559ea6e > Author: Cy Schubert > AuthorDate: 2021-12-22 02:35:12 +0000 > Commit: Cy Schubert > CommitDate: 2022-01-04 02:06:43 +0000 >=20 > ipfilter: Adjust kernel module returns to conform to style(9) >=20 > Adjust ipfilter's kernel module return statements to conform to = style(9). >=20 > MFC after: 1 month > --- > sys/netpfil/ipfilter/netinet/fil.c | 680 = +++++++++++++------------- > sys/netpfil/ipfilter/netinet/ip_auth.c | 70 +-- > sys/netpfil/ipfilter/netinet/ip_dns_pxy.c | 44 +- > sys/netpfil/ipfilter/netinet/ip_dstlist.c | 92 ++-- > sys/netpfil/ipfilter/netinet/ip_fil_freebsd.c | 148 +++--- > sys/netpfil/ipfilter/netinet/ip_frag.c | 88 ++-- > sys/netpfil/ipfilter/netinet/ip_ftp_pxy.c | 190 +++---- > sys/netpfil/ipfilter/netinet/ip_htable.c | 120 ++--- > sys/netpfil/ipfilter/netinet/ip_ipsec_pxy.c | 40 +- > sys/netpfil/ipfilter/netinet/ip_irc_pxy.c | 64 +-- > sys/netpfil/ipfilter/netinet/ip_log.c | 64 +-- > sys/netpfil/ipfilter/netinet/ip_lookup.c | 66 +-- > sys/netpfil/ipfilter/netinet/ip_nat.c | 392 +++++++-------- > sys/netpfil/ipfilter/netinet/ip_nat6.c | 196 ++++---- > sys/netpfil/ipfilter/netinet/ip_netbios_pxy.c | 4 +- > sys/netpfil/ipfilter/netinet/ip_pool.c | 120 ++--- > sys/netpfil/ipfilter/netinet/ip_pptp_pxy.c | 28 +- > sys/netpfil/ipfilter/netinet/ip_proxy.c | 96 ++-- > sys/netpfil/ipfilter/netinet/ip_raudio_pxy.c | 28 +- > sys/netpfil/ipfilter/netinet/ip_rcmd_pxy.c | 30 +- > sys/netpfil/ipfilter/netinet/ip_rpcb_pxy.c | 4 +- > sys/netpfil/ipfilter/netinet/ip_rules.c | 28 +- > sys/netpfil/ipfilter/netinet/ip_scan.c | 58 +-- > sys/netpfil/ipfilter/netinet/ip_state.c | 260 +++++----- > sys/netpfil/ipfilter/netinet/ip_sync.c | 64 +-- > sys/netpfil/ipfilter/netinet/ip_tftp_pxy.c | 36 +- > sys/netpfil/ipfilter/netinet/ipf_rb.h | 6 +- > sys/netpfil/ipfilter/netinet/mlfk_ipl.c | 50 +- > sys/netpfil/ipfilter/netinet/radix_ipf.c | 64 +-- > 29 files changed, 1565 insertions(+), 1565 deletions(-) >=20 > diff --git a/sys/netpfil/ipfilter/netinet/fil.c = b/sys/netpfil/ipfilter/netinet/fil.c > index 282f056e17e8..f5c15b8724d1 100644 > --- a/sys/netpfil/ipfilter/netinet/fil.c > +++ b/sys/netpfil/ipfilter/netinet/fil.c > @@ -624,12 +624,12 @@ ipf_pr_ipv6exthdr(fr_info_t *fin, int multiple, = int proto) > if ((fin->fin_dlen - 8) < 0) { > fin->fin_flx |=3D FI_SHORT; > LBUMPD(ipf_stats[fin->fin_out], fr_v6_ext_short); > - return NULL; > + return(NULL); style(9) includes a space after return. > [...] > @@ -832,11 +832,11 @@ ipf_pr_fragment6(fr_info_t *fin) > /* > * We don't know where the transport layer header (or whatever = is next > * is), as it could be behind destination options (amongst = others) so > - * return the fragment header as the type of packet this is. = Note that > + * return the fragment header as the type of packet this is. = Note that Somehow you=E2=80=99ve lost the space for a few of these. Jess