Re: git: fd9decd0ffee - main - cad/openscad*: Add dependency

Hi Max,

Zitat von Max Brazhnikov <makc@freebsd.org>:

> Hi Michael,
>
>> The branch main has been updated by mr:
>>
>> URL:  
>> https://cgit.FreeBSD.org/ports/commit/?id=fd9decd0ffeec757c3a325242768eadbfac4bb63
>>
>> commit fd9decd0ffeec757c3a325242768eadbfac4bb63
>> Author:     Michael Reifenberger <mr@FreeBSD.org>
>> AuthorDate: 2024-10-14 07:59:41 +0000
>> Commit:     Michael Reifenberger <mr@FreeBSD.org>
>> CommitDate: 2024-10-14 08:03:11 +0000
>>
>>     cad/openscad*: Add dependency
>>
>>     Add audio/alsa-plugins as a dependency
>>
>>     PR:             276276
>>     Reported by:    Greg Balfour
>> ---
>>  cad/openscad-devel/Makefile | 5 +++--
>>  cad/openscad/Makefile       | 5 +++--
>>  2 files changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/cad/openscad-devel/Makefile b/cad/openscad-devel/Makefile
>> index 4fd19cdf56cf..b1876916c84b 100644
>> --- a/cad/openscad-devel/Makefile
>> +++ b/cad/openscad-devel/Makefile
>> @@ -1,6 +1,6 @@
>>  PORTNAME=	openscad
>>  PORTVERSION=	2024.10.11
>> -PORTREVISION=	1
>> +PORTREVISION=	2
>>  CATEGORIES=	cad
>>  PKGNAMESUFFIX=	-devel
>>
>> @@ -19,7 +19,8 @@ BUILD_DEPENDS=	cgal>0:math/cgal \
>>  		${LOCALBASE}/include/glm/glm.hpp:math/glm \
>>  		${LOCALBASE}/include/clipper2/clipper.h:cad/Clipper2 \
>>  		${PYTHON_PKGNAMEPREFIX}numpy>0:math/py-numpy@${PY_FLAVOR}
>> -LIB_DEPENDS=	libzip.so:archivers/libzip \
>> +LIB_DEPENDS=	libasound_module_pcm_oss.so:audio/alsa-plugins \
>
> Firstly, you have already introduced dependency on  
> audio/alsa-plugins for cad/openscad in [1]
> and for cad/openscad-devel in [2]. Secondly, I believe openscad does  
> not use alsa directly,
> but relies on Qt multimedia module, therefore it should not pull  
> alsa-plugins at all.
>

I fixed (hopefully) the redundant dependency to audio/alsa-plugins

audio/alsa-plugins seems to be needed because QT Multimedia depends  
only on alsa libs and not alsa plugins.
In Bug 276276 its stated that without alsa plugins the sound output is  
missing.
Verified by poudriere.

> Cheers,
> Max
>
> [1]  
> https://cgit.freebsd.org/ports/commit/?id=18017953fde7a222042654d5f8b0b1a4dc54cecb
> [2]  
> https://cgit.freebsd.org/ports/commit/?id=a76a16749b3127f0d62a2ac5361353c1c5d3622c


-- 
greetings
---
mike mr@freebsd.org