From nobody Wed Oct 16 09:43:24 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XT5cv1tzxz5ZlHd; Wed, 16 Oct 2024 09:43:27 +0000 (UTC) (envelope-from mr@freebsd.org) Received: from app.eeeit.de (app.eeeit.de [188.68.43.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4XT5ct1bFLz3x5Q; Wed, 16 Oct 2024 09:43:26 +0000 (UTC) (envelope-from mr@freebsd.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 188.68.43.176 is neither permitted nor denied by domain of mr@freebsd.org) smtp.mailfrom=mr@freebsd.org; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=freebsd.org (policy=none) Received: from localhost (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mike@reifenberger.com) by app.eeeit.de (Postfix) with ESMTPSA id A5EE0B1AA2; Wed, 16 Oct 2024 11:43:24 +0200 (CEST) Received: from ip5f5bf9cb.dynamic.kabel-deutschland.de (ip5f5bf9cb.dynamic.kabel-deutschland.de [95.91.249.203]) by app.eeeit.de (Horde Framework) with HTTPS; Wed, 16 Oct 2024 09:43:24 +0000 Date: Wed, 16 Oct 2024 09:43:24 +0000 Message-ID: <20241016094324.Horde.KOO_98-w89Vn1eZ6f77AP9B@app.eeeit.de> From: MR To: Max Brazhnikov Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: fd9decd0ffee - main - cad/openscad*: Add dependency References: <202410140803.49E83R21031126@gitrepo.freebsd.org> <3976679.kAAoriTUSa@mercury> In-Reply-To: <3976679.kAAoriTUSa@mercury> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Disposition: inline X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : No valid SPF, No valid DKIM,none]; ARC_NA(0.00)[]; ASN(0.00)[asn:197540, ipnet:188.68.32.0/20, country:DE]; FREEFALL_USER(0.00)[mr]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; RCPT_COUNT_THREE(0.00)[4] X-Rspamd-Queue-Id: 4XT5ct1bFLz3x5Q X-Spamd-Bar: -- Hi Max, Zitat von Max Brazhnikov : > Hi Michael, > >> The branch main has been updated by mr: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=fd9decd0ffeec757c3a325242768eadbfac4bb63 >> >> commit fd9decd0ffeec757c3a325242768eadbfac4bb63 >> Author: Michael Reifenberger >> AuthorDate: 2024-10-14 07:59:41 +0000 >> Commit: Michael Reifenberger >> CommitDate: 2024-10-14 08:03:11 +0000 >> >> cad/openscad*: Add dependency >> >> Add audio/alsa-plugins as a dependency >> >> PR: 276276 >> Reported by: Greg Balfour >> --- >> cad/openscad-devel/Makefile | 5 +++-- >> cad/openscad/Makefile | 5 +++-- >> 2 files changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/cad/openscad-devel/Makefile b/cad/openscad-devel/Makefile >> index 4fd19cdf56cf..b1876916c84b 100644 >> --- a/cad/openscad-devel/Makefile >> +++ b/cad/openscad-devel/Makefile >> @@ -1,6 +1,6 @@ >> PORTNAME= openscad >> PORTVERSION= 2024.10.11 >> -PORTREVISION= 1 >> +PORTREVISION= 2 >> CATEGORIES= cad >> PKGNAMESUFFIX= -devel >> >> @@ -19,7 +19,8 @@ BUILD_DEPENDS= cgal>0:math/cgal \ >> ${LOCALBASE}/include/glm/glm.hpp:math/glm \ >> ${LOCALBASE}/include/clipper2/clipper.h:cad/Clipper2 \ >> ${PYTHON_PKGNAMEPREFIX}numpy>0:math/py-numpy@${PY_FLAVOR} >> -LIB_DEPENDS= libzip.so:archivers/libzip \ >> +LIB_DEPENDS= libasound_module_pcm_oss.so:audio/alsa-plugins \ > > Firstly, you have already introduced dependency on > audio/alsa-plugins for cad/openscad in [1] > and for cad/openscad-devel in [2]. Secondly, I believe openscad does > not use alsa directly, > but relies on Qt multimedia module, therefore it should not pull > alsa-plugins at all. > I fixed (hopefully) the redundant dependency to audio/alsa-plugins audio/alsa-plugins seems to be needed because QT Multimedia depends only on alsa libs and not alsa plugins. In Bug 276276 its stated that without alsa plugins the sound output is missing. Verified by poudriere. > Cheers, > Max > > [1] > https://cgit.freebsd.org/ports/commit/?id=18017953fde7a222042654d5f8b0b1a4dc54cecb > [2] > https://cgit.freebsd.org/ports/commit/?id=a76a16749b3127f0d62a2ac5361353c1c5d3622c -- greetings --- mike mr@freebsd.org