Re: git: 86bff3d95b03 - main - www/xcaddy: add missing RUN_DEPENDS on lang/go.

From: Daniel Engberg <daniel.engberg.lists_at_pyret.net>
Date: Wed, 29 May 2024 23:46:46 UTC 
On 2024-05-29T10:24:18.000+02:00, Jimmy Olgeni <olgeni@FreeBSD.org>
wrote:

> The branch main has been updated by olgeni:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=86bff3d95b03955a22d181fe064f81db968a1bb6
> 
> commit 86bff3d95b03955a22d181fe064f81db968a1bb6
> 
> Author:     Jimmy Olgeni <olgeni@FreeBSD.org>
> 
> AuthorDate: 2024-05-29 08:19:39 +0000
> 
> Commit:     Jimmy Olgeni <olgeni@FreeBSD.org>
> 
> CommitDate: 2024-05-29 08:23:58 +0000
> 
>     www/xcaddy: add missing RUN_DEPENDS on lang/go.
> 
>     
> 
>     xcaddy uses go to build custom releases of caddy, so it actually needs
> 
>     it at runtime.
> 
>     
> 
>     PR:             279358
> 
>     Reported by:    Robert William Vesterman <bob@vesterman.com>
> 
> ---
> 
>  www/xcaddy/Makefile | 4 ++++
> 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/www/xcaddy/Makefile b/www/xcaddy/Makefile
> 
> index d8dbd019679e..0fc20011a2eb 100644
> 
> --- a/www/xcaddy/Makefile
> 
> +++ b/www/xcaddy/Makefile
> 
> @@ -1,6 +1,7 @@
> 
>  PORTNAME=    xcaddy
> 
>  DISTVERSIONPREFIX=    v
> 
>  DISTVERSION=    0.4.1
> 
> +PORTREVISION=    1
> 
>  CATEGORIES=    www
> 
>  DIST_SUBDIR=    xcaddy
> 
>  
> 
> @@ -11,6 +12,9 @@ WWW=        https://github.com/caddyserver/xcaddy
> 
>  LICENSE=    APACHE20
> 
>  LICENSE_FILE=    ${WRKSRC}/LICENSE
> 
>  
> 
> +# xcaddy actually needs to run the go command to perform builds
> 
> +RUN_DEPENDS=    go:lang/go
> 
> +
> 
>  USES=        go:modules
> 
>  
> 
>  USE_GITHUB=    yes

Hi,

Please use the helper instead of RUN_DEPENDS

https://cgit.freebsd.org/ports/tree/Mk/Uses/go.mk#n16

Best regards,

Daniel